linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Sinan Kaya <Okaya@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	Oza Pawandeep <poza@codeaurora.org>,
	Keith Busch <keith.busch@intel.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V5 3/3] PCI: Mask and unmask hotplug interrupts during reset
Date: Mon, 9 Jul 2018 18:00:08 +0200	[thread overview]
Message-ID: <20180709160008.GA1490@wunner.de> (raw)
In-Reply-To: <CAK9iUCMcic5mzGiT20KNxgwPo6AuajHFsoj7GOjSht5SwrQevg@mail.gmail.com>

On Mon, Jul 09, 2018 at 08:48:44AM -0600, Sinan Kaya wrote:
> On 7/8/18, Lukas Wunner <lukas@wunner.de> wrote:
> > On Tue, Jul 03, 2018 at 11:43:26AM -0400, Sinan Kaya wrote:
> > > My solution doesn't help if link down interrupt is observed before the
> > > AER
> > > or DPC services.
> >
> > If pciehp gets an interrupt quicker than dpc/aer, it will (at least with
> > my patches) remove all devices, check if the presence bit is set,
> > and if so, try to bring the slot up again.
> 
> Hotplug driver should only observe a link down interrupt. Link would
> come up in response to a secondary bus reset initiated by the AER
> driver.

PCIe hotplug doesn't have separate Link Down and Link Up interrupts,
there is only a Link State *Changed* event.

> Can you point me to the code that would bring up the link in hp code?

I was referring to the situation with my recently posted pciehp patches
applied, in particular patch [21/32] ("PCI: pciehp: Become resilient to
missed events"):
https://patchwork.ozlabs.org/patch/930389/

When I get a presence or link changed event, I turn the slot off.  That
includes removing all devices in the slot.  Because even if the slot is
still occupied or link is up, there was definitely a change and the safe
behavior is to assume that the card in the slot is now a different one
than before.

Afterwards, I check if the slot is occupied or link is up.  If either
of those conditions is true, I try to bring the slot up again.

Thanks,

Lukas

  reply	other threads:[~2018-07-09 16:00 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1530571967-19099-1-git-send-email-okaya@codeaurora.org>
2018-07-02 22:52 ` [PATCH V5 1/3] PCI: pciehp: implement mask and unmask interrupt functions Sinan Kaya
2018-07-02 22:52 ` [PATCH V5 2/3] PCI: pciehp: reuse pciehp_mask/unmask_irq() in reset_slot() Sinan Kaya
2018-07-02 22:52 ` [PATCH V5 3/3] PCI: Mask and unmask hotplug interrupts during reset Sinan Kaya
2018-07-03  8:34   ` Lukas Wunner
2018-07-03 10:52     ` poza
2018-07-03 12:04       ` okaya
2018-07-03 11:30     ` okaya
2018-07-03 13:11       ` poza
2018-07-03 13:25         ` Sinan Kaya
2018-07-03 13:31           ` Sinan Kaya
2018-07-03 13:59             ` Lukas Wunner
2018-07-03 14:10               ` poza
2018-07-03 14:17                 ` Lukas Wunner
2018-07-03 15:34               ` Sinan Kaya
2018-07-29 12:32         ` Lukas Wunner
2018-07-03 14:12       ` Lukas Wunner
2018-07-03 14:29         ` poza
2018-07-29 12:19       ` Lukas Wunner
2018-07-03 14:34   ` Lukas Wunner
2018-07-03 15:12     ` poza
2018-07-03 15:49       ` Sinan Kaya
2018-07-03 15:43     ` Sinan Kaya
2018-07-08 17:14       ` Lukas Wunner
2018-07-09 14:48         ` Sinan Kaya
2018-07-09 16:00           ` Lukas Wunner [this message]
2018-07-10 18:30             ` Sinan Kaya
2018-07-20 20:01               ` Bjorn Helgaas
2018-07-21  2:58                 ` Sinan Kaya
2018-07-21  6:07                   ` Sinan Kaya
2018-07-25  8:29                     ` poza
2018-07-29 18:02                   ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180709160008.GA1490@wunner.de \
    --to=lukas@wunner.de \
    --cc=Okaya@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=keith.busch@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=poza@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).