From: Matthias Kaehlcke <mka@chromium.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Eduardo Valentin <edubezval@gmail.com>,
smohanad@codeaurora.org,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
lakml <linux-arm-kernel@lists.infradead.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v4 6/6] arm64: dts: sdm845: Add tsens nodes
Date: Mon, 9 Jul 2018 09:10:19 -0700 [thread overview]
Message-ID: <20180709161019.GN129942@google.com> (raw)
In-Reply-To: <CAHLCerP0z-G+YqXOe8VYSTVPfSYiR+yywskijiD7y0Lz=2AQQQ@mail.gmail.com>
On Mon, Jul 09, 2018 at 09:34:55PM +0530, Amit Kucheria wrote:
> On Mon, Jul 9, 2018 at 9:31 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> > On Mon, Jul 09, 2018 at 04:56:51PM +0530, Amit Kucheria wrote:
> >> On Wed, Jul 4, 2018 at 3:18 AM, Matthias Kaehlcke <mka@chromium.org> wrote:
> >> > Hi,
> >> >
> >> > On Mon, Jul 02, 2018 at 06:14:09PM +0530, Amit Kucheria wrote:
> >> >> SDM845 has two tsens blocks, one with 13 sensors and the other with 8
> >> >> sensors.
> >> >>
> >> >> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> >> >> ---
> >> >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 16 ++++++++++++++++
> >> >> 1 file changed, 16 insertions(+)
> >> >>
> >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> >> >> index cdaabeb..edf8505 100644
> >> >> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> >> >> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> >> >> @@ -221,6 +221,22 @@
> >> >> #interrupt-cells = <2>;
> >> >> };
> >> >>
> >> >> + tsens0: tsens@c222000 {
> >> >> + compatible = "qcom,tsens-v2.4.0", "qcom,tsens-v2";
> >> >> + reg = <0xc263000 0x1ff>, /* TM */
> >> >> + <0xc222000 0x1ff>; /* SROT */
> >> >> + #qcom,sensors = <13>;
> >> >> + #thermal-sensor-cells = <1>;
> >> >> + };
> >> >> +
> >> >> + tsens1: tsens@c223000 {
> >> >> + compatible = "qcom,tsens-v2.4.0", "qcom,tsens-v2";
> >> >> + reg = <0xc265000 0x1ff>, /* TM */
> >> >> + <0xc223000 0x1ff>; /* SROT */
> >> >> + #qcom,sensors = <8>;
> >> >> + #thermal-sensor-cells = <1>;
> >> >> + };
> >> >> +
> >> >> spmi_bus: spmi@c440000 {
> >> >> compatible = "qcom,spmi-pmic-arb";
> >> >> reg = <0xc440000 0x1100>,
> >> >
> >> > I tested this series on an SDM845 board. Temperatures can be read from
> >> > the tsens0 sensors, however for tsens1 sensors I get:
> >> >
> >> > cat temp
> >> > cat: temp: No data available
> >> >
> >> > TRDY_READY_BIT set when reading TRDY_OFFSET in get_temp_tsens_v2().
> >> > Unfortunately I currently have no documentation of the registers or the
> >> > thermal sensors in general and couldn't investigate further.
> >> >
> >> > Any idea what could be the problem?
> >>
> >> Strangely enough, I'm seeing this now after rebuilding my integration
> >> branch to test some other bits.
> >>
> >> I've sent another version with this patch removed while I investigate
> >> this. Could you check if you're able to read all 8 sensors with v5?
> >
> > With v6 all sensors can be read, thanks!
>
> Great! Would it be OK to add your Tested-by tag?
Yep
next prev parent reply other threads:[~2018-07-09 16:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 12:44 [PATCH v4 0/6] thermal: tsens: Refactoring for TSENSv2 IP Amit Kucheria
2018-07-02 12:44 ` [PATCH v4 1/6] thermal: tsens: Get rid of unused fields in structure Amit Kucheria
2018-07-02 12:44 ` [PATCH v4 2/6] dt: qcom: 8996: thermal: Move to DT initialisation Amit Kucheria
2018-07-02 18:48 ` Bjorn Andersson
2018-07-02 12:44 ` [PATCH v4 3/6] thermal: tsens: Rename tsens-8996 to tsens-v2 for reuse Amit Kucheria
2018-07-02 18:55 ` Bjorn Andersson
2018-07-04 12:38 ` Amit Kucheria
2018-07-02 12:44 ` [PATCH v4 4/6] thermal: tsens: Add support for SDM845 Amit Kucheria
2018-07-02 18:51 ` Bjorn Andersson
2018-07-03 16:26 ` Rob Herring
2018-07-04 17:26 ` Amit Kucheria
2018-07-05 20:37 ` Rob Herring
2018-07-06 5:13 ` Amit Kucheria
2018-07-06 17:47 ` Rob Herring
2018-07-02 12:44 ` [PATCH v4 5/6] thermal: tsens: Check if we have valid data before reading Amit Kucheria
2018-07-02 17:47 ` Eduardo Valentin
2018-07-02 12:44 ` [PATCH v4 6/6] arm64: dts: sdm845: Add tsens nodes Amit Kucheria
2018-07-02 18:50 ` Bjorn Andersson
2018-07-03 21:48 ` Matthias Kaehlcke
2018-07-09 11:26 ` Amit Kucheria
2018-07-09 16:01 ` Matthias Kaehlcke
2018-07-09 16:04 ` Amit Kucheria
2018-07-09 16:10 ` Matthias Kaehlcke [this message]
2018-07-06 17:31 ` Stephen Boyd
2018-07-09 11:27 ` Amit Kucheria
2018-07-02 14:00 ` [PATCH v4 0/6] thermal: tsens: Refactoring for TSENSv2 IP Amit Kucheria
2018-07-02 17:53 ` Eduardo Valentin
2018-07-09 11:30 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709161019.GN129942@google.com \
--to=mka@chromium.org \
--cc=amit.kucheria@linaro.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=smohanad@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).