From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Maninder Singh <maninder1.s@samsung.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vaneet Narang <v.narang@samsung.com>,
PANKAJ MISHRA <pankaj.m@samsung.com>
Subject: Re: linux-next: build warning after merge of the printk tree
Date: Tue, 10 Jul 2018 22:15:47 +0900 [thread overview]
Message-ID: <20180710131547.GA526@tigerII.localdomain> (raw)
In-Reply-To: <20180710091909.rwgtahcew6grhd6n@pathway.suse.cz>
On (07/10/18 11:19), Petr Mladek wrote:
> suppress_message_printing() is not longer called in console_unlock().
> Therefore it is not longer needed with disabled CONFIG_PRINTK.
>
> This fixes the warning:
>
> kernel/printk/printk.c:2033:13: warning: ‘suppress_message_printing’ defined but not used [-Wunused-function]
> static bool suppress_message_printing(int level) { return false; }
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Suggested-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Petr Mladek <pmladek@suse.com>
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Happens all the time to me as well. I'd rather remove CONFIG_PRINTK
at this point ;)
-ss
next prev parent reply other threads:[~2018-07-10 13:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 6:45 linux-next: build warning after merge of the printk tree Stephen Rothwell
[not found] ` <CGME20180710064527epcas1p16fd9ad765711d69264b3251890bbcc2e@epcms5p5>
2018-07-10 7:16 ` Maninder Singh
2018-07-10 9:19 ` Petr Mladek
2018-07-10 11:53 ` [PATCH] printk: Fix warning about unused suppress_message_printing kbuild test robot
2018-07-10 13:15 ` Sergey Senozhatsky [this message]
2021-07-20 6:24 linux-next: build warning after merge of the printk tree Stephen Rothwell
2021-07-20 12:18 ` Chris Down
2021-07-20 12:22 ` Chris Down
2021-07-25 21:16 ` Jonathan Corbet
2021-07-26 12:28 ` Petr Mladek
2021-07-26 13:07 ` Chris Down
2022-11-22 7:10 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710131547.GA526@tigerII.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=pankaj.m@samsung.com \
--cc=pmladek@suse.com \
--cc=sfr@canb.auug.org.au \
--cc=v.narang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).