From: Mark Brown <broonie@kernel.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
Jassi Brar <jaswinder.singh@linaro.org>
Subject: Re: [PATCH v2 2/2] regulator: uniphier: add regulator driver for UniPhier SoC
Date: Tue, 10 Jul 2018 18:44:51 +0100 [thread overview]
Message-ID: <20180710174451.GE8104@sirena.org.uk> (raw)
In-Reply-To: <1531186037-16630-3-git-send-email-hayashi.kunihiko@socionext.com>
[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]
On Tue, Jul 10, 2018 at 10:27:17AM +0900, Kunihiko Hayashi wrote:
> +static int uniphier_regulator_enable(struct regulator_dev *rdev)
> +{
> + struct uniphier_regulator_priv *priv = rdev_get_drvdata(rdev);
> +
> + return regmap_update_bits(priv->regmap, rdev->desc->enable_reg,
> + rdev->desc->enable_mask,
> + rdev->desc->enable_val);
> +}
This is just regulator_enable_regmap() isn't it? Same for disable,
unless I'm missing something (which is possible).
> +static int uniphier_regulator_is_enabled(struct regulator_dev *rdev)
> +{
> + struct uniphier_regulator_priv *priv = rdev_get_drvdata(rdev);
> + unsigned int val;
> + int ret = -EINVAL;
> +
> + regmap_read(priv->regmap, rdev->desc->enable_reg, &val);
> + val &= rdev->desc->enable_mask;
> +
> + if (val == rdev->desc->enable_val)
> + ret = 1;
> + else if (val == rdev->desc->disable_val)
> + ret = 0;
> +
> + return ret;
> +}
This isn't *quite* regulator_is_enabled_regmap() as it explicitly checks
if the disable value is set and errors otherwise which would be a good
fix for that. Could you do a patch for that?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-07-10 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 1:27 [PATCH v2 0/2] regulator: add new UniPhier regulator support Kunihiko Hayashi
2018-07-10 1:27 ` [PATCH v2 1/2] dt-bindings: regulator: add DT bindings for UniPhier regulator Kunihiko Hayashi
2018-07-11 9:33 ` Applied "dt-bindings: regulator: add DT bindings for UniPhier regulator" to the regulator tree Mark Brown
2018-07-10 1:27 ` [PATCH v2 2/2] regulator: uniphier: add regulator driver for UniPhier SoC Kunihiko Hayashi
2018-07-10 17:44 ` Mark Brown [this message]
2018-07-11 2:31 ` Kunihiko Hayashi
2018-07-11 9:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710174451.GE8104@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=jaswinder.singh@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masami.hiramatsu@linaro.org \
--cc=robh+dt@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).