From: Joel Fernandes <joel@joelfernandes.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Nicholas Piggin <npiggin@gmail.com>,
Joel Fernandes <joel.opensrc@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/irqtrace: only call trace_hardirqs_on/off when state changes
Date: Tue, 10 Jul 2018 22:58:09 -0700 [thread overview]
Message-ID: <20180711055809.GA16473@joelaf.mtv.corp.google.com> (raw)
In-Reply-To: <20180710214457.480826ab@vmware.local.home>
On Tue, Jul 10, 2018 at 09:44:57PM -0400, Steven Rostedt wrote:
> On Wed, 2 May 2018 10:12:14 +1000
> Nicholas Piggin <npiggin@gmail.com> wrote:
>
> > > I have mixed feelings about this patch, I am Ok with this patch but I
> > > suggest its sent with the follow-up patch that shows its use of this.
> > > And also appreciate if such a follow-up patch is rebased onto the IRQ
> > > tracepoint work: https://patchwork.kernel.org/patch/10373129/
> > >
> > > What do you think?
> >
> > I'll try to dig it up and resend. Thanks for the feedback on it.
>
> Joel,
>
> With your latest patches, is this obsolete?
Yes, that's right. This patch isn't needed for what I was doing (improving
the performance of the irq disable/enable path). I didn't see any performance
improvement with this patch. Instead, the patches in my series use SRCU to
improve the performance of the tracepoints.
thanks,
- Joel
prev parent reply other threads:[~2018-07-11 5:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 16:15 [PATCH] tracing/irqtrace: only call trace_hardirqs_on/off when state changes Nicholas Piggin
2018-05-01 18:46 ` Steven Rostedt
2018-05-01 19:19 ` Peter Zijlstra
2018-05-01 19:38 ` Steven Rostedt
2018-05-01 19:48 ` Peter Zijlstra
2018-05-01 20:00 ` Steven Rostedt
2018-05-01 21:15 ` Joel Fernandes
2018-05-02 0:12 ` Nicholas Piggin
2018-07-11 1:44 ` Steven Rostedt
2018-07-11 5:58 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711055809.GA16473@joelaf.mtv.corp.google.com \
--to=joel@joelfernandes.org \
--cc=joel.opensrc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).