From: Steven Rostedt <rostedt@goodmis.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Why the mce reverts in 4.16-rt?
Date: Wed, 11 Jul 2018 08:51:01 -0400 [thread overview]
Message-ID: <20180711085101.553face7@gandalf.local.home> (raw)
In-Reply-To: <20180711072311.cprdgb2xqwag2iem@linutronix.de>
On Wed, 11 Jul 2018 09:23:11 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> On 2018-07-10 20:56:24 [-0400], Steven Rostedt wrote:
> > Hi Sebastian,
> Hi Steven,
>
> > I'm looking at backporting patches from 4.16-rt and noticed that you
> > have:
> >
> > Revert "x86: Convert mce timer to hrtimer"
> > Revert "x86/mce: use swait queue for mce wakeups"
> >
> > With no explanation to why they were reverted. When did things change?
> > Should this be 4.14-rt material?
>
> from the announce email:
> | Changes since v4.16.8-rt2:
> |
> | - Drop two MCE related patches. They are no longer required since the
> | timer wheel rework.
Thanks, still would have preferred a comment in the revert commit
message ;-)
>
> The timer wheel rework made it possible to have a raw_spin_lock_t in the
> timer_list timer. The problem with MCE was that it enqueued a timer from
> hardirq context which is now possible. So the patches are no longer
> required. This revert does not fix a bug in v4.14 nor does it break
> anything.
OK, even though this doesn't fix anything, I think I'll still
backport it.
-- Steve
prev parent reply other threads:[~2018-07-11 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 0:56 Why the mce reverts in 4.16-rt? Steven Rostedt
2018-07-11 7:23 ` Sebastian Andrzej Siewior
2018-07-11 12:51 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711085101.553face7@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).