From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E65DC5CFEB for ; Wed, 11 Jul 2018 08:55:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F21E8208FA for ; Wed, 11 Jul 2018 08:55:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F21E8208FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732357AbeGKI6g (ORCPT ); Wed, 11 Jul 2018 04:58:36 -0400 Received: from mail.bootlin.com ([62.4.15.54]:41540 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbeGKI6g (ORCPT ); Wed, 11 Jul 2018 04:58:36 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id BB73F20733; Wed, 11 Jul 2018 10:55:17 +0200 (CEST) Received: from localhost (AAubervilliers-681-1-12-56.w90-88.abo.wanadoo.fr [90.88.133.56]) by mail.bootlin.com (Postfix) with ESMTPSA id 93F1F206A6; Wed, 11 Jul 2018 10:55:17 +0200 (CEST) Date: Wed, 11 Jul 2018 10:55:17 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Paul Kocialkowski , Linux Media Mailing List , devicetree , linux-arm-kernel , linux-kernel , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Marco Franchi , Icenowy Zheng , Hans Verkuil , Keiichi Watanabe , Jonathan Corbet , Smitha T Murthy , Tom Saeger , Andrzej Hajda , "David S . Miller" , Greg Kroah-Hartman , Andrew Morton , Randy Dunlap , Arnd Bergmann , Geert Uytterhoeven , Laurent Pinchart , Jacob Chen , Neil Armstrong , Benoit Parrot , Todor Tomov , Alexandre Courbot , Sakari Ailus , Andy Shevchenko , Pawel Osciak , Ricardo Ribalda Delgado , Hans de Goede , Sami Tolvanen , Niklas =?utf-8?Q?S=C3=B6derlund?= , linux-sunxi , Thomas Petazzoni , Hugues Fruchet , Randy Li Subject: Re: [PATCH v5 05/22] dt-bindings: sram: sunxi: Populate valid sections compatibles Message-ID: <20180711085517.myjn5ttiwqiolobz@flea> References: <20180710080114.31469-1-paul.kocialkowski@bootlin.com> <20180710080114.31469-6-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4x5rkbvkq66mckhl" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180622 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4x5rkbvkq66mckhl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 10, 2018 at 10:47:07PM +0800, Chen-Yu Tsai wrote: > On Tue, Jul 10, 2018 at 4:00 PM, Paul Kocialkowski > wrote: > > This adds a list of valid SRAM sections compatibles for the A13, A20, > > A23 and H3 platforms. Per-platform compatibles are introduced for the > > SRAM sections of these platforms, with the A10 compatibles also listed > > as valid when applicable. > > > > In particular, compatibles for the C1 SRAM section are introduced. >=20 > You should probably mention that this is not an exhaustive list. In > particular, the C2 and C3 (sun5i) mappings are still missing. >=20 > > > > Signed-off-by: Paul Kocialkowski > > --- > > .../devicetree/bindings/sram/sunxi-sram.txt | 25 +++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sram/sunxi-sram.txt b/Do= cumentation/devicetree/bindings/sram/sunxi-sram.txt > > index 156a02ab6b54..07c53c5214a0 100644 > > --- a/Documentation/devicetree/bindings/sram/sunxi-sram.txt > > +++ b/Documentation/devicetree/bindings/sram/sunxi-sram.txt > > @@ -32,8 +32,33 @@ once again the representation described in the mmio-= sram binding. > > > > The valid sections compatible for A10 are: > > - allwinner,sun4i-a10-sram-a3-a4 > > + - allwinner,sun4i-a10-sram-c1 > > - allwinner,sun4i-a10-sram-d > > > > +The valid sections compatible for A13 are: > > + - allwinner,sun5i-a13-sram-a3-a4 > > + - allwinner,sun4i-a10-sram-a3-a4 > > + - allwinner,sun5i-a13-sram-c1 > > + - allwinner,sun4i-a10-sram-c1 > > + - allwinner,sun5i-a13-sram-d > > + - allwinner,sun4i-a10-sram-d > > + > > +The valid sections compatible for A20 are: > > + - allwinner,sun7i-a20-sram-a3-a4 > > + - allwinner,sun4i-a10-sram-a3-a4 > > + - allwinner,sun7i-a20-sram-c1 > > + - allwinner,sun4i-a10-sram-c1 > > + - allwinner,sun7i-a20-sram-d > > + - allwinner,sun4i-a10-sram-d > > + > > +The valid sections compatible for A23/A33 are: > > + - allwinner,sun8i-a23-sram-c1 > > + - allwinner,sun4i-a10-sram-c1 > > + > > +The valid sections compatible for H3 are: > > + - allwinner,sun8i-h3-sram-c1 > > + - allwinner,sun4i-a10-sram-c1 >=20 > I'm not quite sure why we want to list these... I think it makes more sen= se > to just have the SoC specific compatible. They are tied to the controls > after all. Maybe Rob has a different opinion? We had that discussion not so long ago, and the outcome was to list the SoC specific and the fallback compatibles on the same line. I've amended the patch to do so and applied. (and added the mention of the C2 and C3 SRAMs as you suggested) Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --4x5rkbvkq66mckhl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAltFxfQACgkQ0rTAlCFN r3Tyig//VvvkaNDStwST2xmuMuiwXX/uMwSgYyvU97azlGWDwVrYmWRPohGw4SHk Ctta2Re24CViAK/KWlagk852PcUgpSmGOPWwjKKvkmJ5J6Pce5uCuWsRxOBga7tA fHcM5zMCuaPd7SQmaz/J+8sXlD0Z0YHuG/MNjpKvs4Rp1GuXWOAe+XmidtatWvgP ZwNHYHkO9ZpVgff+eftm5sXCLBHhqcRP1sWFmmfiu6VJCIv/VcFPWbBBXX7efxDU N/KHGsr3jf34gGe3XLo+Xcm9lvwdwHQyB2yRpxAS65AbpsM3YzzcsIrkCdhWTxjo x/ZvfMVeUYnUWRFdmyqyvSWLRX+B6TPcuTHgl2IwXaoLMeIHVOw0af6dnHx9PwN4 17fJp1iFTgEH4+KJRQC3reSSOK528jWp3j3/60Hmbigfgeq21U6QKaQduhHRLimG yXnUqIME991dVJfMRsm+H6qIROVllyq7fOFYN0SK+yKnTudj+xVq6FXfwyGMPS5K 3vluGn1+ZCLRFLVYa1VCHj1GpfHOj7SSpz+9EiyuW+7mx58IR0Ip4Z8fYe/5Yk5b 4Udj8ZaC8V0kj7d8ZDh8ztb8O1y45vu+m1wiUOTnj+mZoe+JZoh9cg8jGUsyh3it hQNtelN3DVQ+HKxriLiGeI5bFqJn/BsdSf4n7KhbRREi38uFK9k= =4XM2 -----END PGP SIGNATURE----- --4x5rkbvkq66mckhl--