From: Johan Hovold <johan@kernel.org>
To: Keerthy <j-keerthy@ti.com>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
t-kristo@ti.com, linux-rtc@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
johan@kernel.org
Subject: Re: [PATCH v3 1/4] rtc: omap: Cut down the shutdown time from 2 seconds to 1 sec
Date: Wed, 11 Jul 2018 15:54:44 +0200 [thread overview]
Message-ID: <20180711135444.GC12517@localhost> (raw)
In-Reply-To: <1531205452-6086-2-git-send-email-j-keerthy@ti.com>
On Tue, Jul 10, 2018 at 12:20:49PM +0530, Keerthy wrote:
> Cut down the shutdown time from 2 seconds to 1 sec. In case of roll
> over try again.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/rtc/rtc-omap.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
> index 323ff55..14f2241 100644
> --- a/drivers/rtc/rtc-omap.c
> +++ b/drivers/rtc/rtc-omap.c
> @@ -441,11 +441,12 @@ static void omap_rtc_power_off(void)
> val = rtc_readl(rtc, OMAP_RTC_PMIC_REG);
> rtc_writel(rtc, OMAP_RTC_PMIC_REG, val | OMAP_RTC_PMIC_POWER_EN_EN);
>
> - /* set alarm two seconds from now */
> +again:
> + /* set alarm one second from now */
> omap_rtc_read_time_raw(rtc, &tm);
> bcd2tm(&tm);
> rtc_tm_to_time(&tm, &now);
> - rtc_time_to_tm(now + 2, &tm);
> + rtc_time_to_tm(now + 1, &tm);
>
> if (tm2bcd(&tm) < 0) {
> dev_err(&rtc->rtc->dev, "power off failed\n");
> @@ -455,6 +456,10 @@ static void omap_rtc_power_off(void)
>
> rtc_wait_not_busy(rtc);
>
> + /* Our calculations started right before the rollover, try again */
> + if (seconds != rtc_read(omap_rtc_power_off_rtc, OMAP_RTC_SECONDS_REG))
> + goto again;
First, this doesn't even compile.
Second, nothing is preventing the rollover from happening here after the
check.
> +
> rtc_write(rtc, OMAP_RTC_ALARM2_SECONDS_REG, tm.tm_sec);
> rtc_write(rtc, OMAP_RTC_ALARM2_MINUTES_REG, tm.tm_min);
> rtc_write(rtc, OMAP_RTC_ALARM2_HOURS_REG, tm.tm_hour);
Johan
next prev parent reply other threads:[~2018-07-11 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 6:50 [PATCH v3 0/4] rtc: OMAP: Add support for rtc-only mode Keerthy
2018-07-10 6:50 ` [PATCH v3 1/4] rtc: omap: Cut down the shutdown time from 2 seconds to 1 sec Keerthy
2018-07-11 13:54 ` Johan Hovold [this message]
2018-07-11 16:16 ` J, KEERTHY
2018-07-10 6:50 ` [PATCH v3 2/4] rtc: OMAP: Add support for rtc-only mode Keerthy
2018-07-10 6:50 ` [PATCH v3 3/4] rtc: omap: use of_device_is_system_power_controller function Keerthy
2018-07-10 6:50 ` [PATCH v3 4/4] rtc: interface: Add power_off_program to rtc_class_ops Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711135444.GC12517@localhost \
--to=johan@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).