From: kbuild test robot <lkp@intel.com>
To: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
Cc: kbuild-all@01.org, Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Neuling <mikey@neuling.org>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Akshay Adiga <akshay.adiga@linux.vnet.ibm.com>,
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
Murilo Opsfelder Araujo <muriloo@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
"Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
Subject: Re: [PATCH v3 2/2] powerpc: Enable CPU_FTR_ASYM_SMT for interleaved big-cores
Date: Wed, 11 Jul 2018 16:32:30 +0800 [thread overview]
Message-ID: <201807111509.TCWIHpaa%fengguang.wu@intel.com> (raw)
In-Reply-To: <03b97f95b42a9044a4280c318a92ac5e53e79828.1530867876.git.ego@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 3299 bytes --]
Hi Gautham,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on v4.18-rc4 next-20180710]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Gautham-R-Shenoy/powerpc-Detect-the-presence-of-big-cores-via-ibm-thread-groups/20180706-174756
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-g5_defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
In file included from include/linux/static_key.h:1:0,
from include/linux/context_tracking_state.h:6,
from include/linux/vtime.h:5,
from include/linux/hardirq.h:8,
from include/linux/interrupt.h:11,
from include/linux/serial_core.h:25,
from include/linux/serial_8250.h:14,
from arch/powerpc/kernel/setup-common.c:33:
arch/powerpc/kernel/setup-common.c: In function 'smp_setup_cpu_maps':
>> arch/powerpc/kernel/setup-common.c:777:25: error: 'cpu_feature_keys' undeclared (first use in this function); did you mean 'setup_feature_keys'?
static_branch_enable(&cpu_feature_keys[key]);
^
include/linux/jump_label.h:434:55: note: in definition of macro 'static_branch_enable'
#define static_branch_enable(x) static_key_enable(&(x)->key)
^
arch/powerpc/kernel/setup-common.c:777:25: note: each undeclared identifier is reported only once for each function it appears in
static_branch_enable(&cpu_feature_keys[key]);
^
include/linux/jump_label.h:434:55: note: in definition of macro 'static_branch_enable'
#define static_branch_enable(x) static_key_enable(&(x)->key)
^
vim +777 arch/powerpc/kernel/setup-common.c
772
773 if (has_interleaved_big_cores) {
774 int key = __builtin_ctzl(CPU_FTR_ASYM_SMT);
775
776 cur_cpu_spec->cpu_features |= CPU_FTR_ASYM_SMT;
> 777 static_branch_enable(&cpu_feature_keys[key]);
778 pr_info("Detected interleaved big-cores\n");
779 }
780
781 /* Initialize CPU <=> thread mapping/
782 *
783 * WARNING: We assume that the number of threads is the same for
784 * every CPU in the system. If that is not the case, then some code
785 * here will have to be reworked
786 */
787 cpu_init_thread_core_maps(nthreads);
788
789 /* Now that possible cpus are set, set nr_cpu_ids for later use */
790 setup_nr_cpu_ids();
791
792 free_unused_pacas();
793 }
794 #endif /* CONFIG_SMP */
795
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19895 bytes --]
next prev parent reply other threads:[~2018-07-11 8:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 9:05 [PATCH v3 0/2] powerpc: Detection and scheduler optimization for POWER9 bigcore Gautham R. Shenoy
2018-07-06 9:05 ` [PATCH v3 1/2] powerpc: Detect the presence of big-cores via "ibm,thread-groups" Gautham R. Shenoy
2018-07-08 16:03 ` [PATCH v3 1/2] powerpc: Detect the presence of big-cores via "ibm, thread-groups" Murilo Opsfelder Araujo
2018-07-09 3:52 ` Joe Perches
2018-07-11 9:54 ` Gautham R Shenoy
2018-07-06 9:05 ` [PATCH v3 2/2] powerpc: Enable CPU_FTR_ASYM_SMT for interleaved big-cores Gautham R. Shenoy
2018-07-11 8:32 ` kbuild test robot [this message]
2018-07-16 5:25 ` Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201807111509.TCWIHpaa%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=akshay.adiga@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=ego@linux.vnet.ibm.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=muriloo@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=shilpa.bhat@linux.vnet.ibm.com \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).