From: Steven Rostedt <rostedt@goodmis.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Hans de Goede <hdegoede@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Petr Mladek <pmladek@suse.com>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable
Date: Wed, 11 Jul 2018 15:19:11 -0400 [thread overview]
Message-ID: <20180711151911.2ea40200@gandalf.local.home> (raw)
In-Reply-To: <CAKMK7uFuZ6NJOKHG6PRNLUytE4m6ZUdMakwLx9Ns39OwvTneWQ@mail.gmail.com>
On Wed, 11 Jul 2018 19:56:02 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:
> > Have you seen Steven's suggestion which he send about the same time
> > as your mail I'm replying to here ? I personally think that doing
> > something like that makes sense (for as long as we have the need
> > for the lockless_fb_register debug hack).
> >
> > Note I've 2 patches ready to go to only fix this in fbcon.c, but I
> > think a more thorough fix makes sense.
>
> Yeah Steven's suggestion looks reasonable to fix this all for good.
> The #if 1 predates git history, so no idea why it was added or by whom
> :-)
I just sent the patch. If the printk maintainers take it, then you can
update the fb driver to set the ignore_console_lock_warning when
lockless_fb_register is set.
-- Steve
next prev parent reply other threads:[~2018-07-11 19:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180628090357epcas5p28361ab4b3ce11c179a167548f4851983@epcas5p2.samsung.com>
2018-06-28 9:03 ` [PATCH v5 0/3] console/fbcon: Add support for deferred console takeover Hans de Goede
2018-06-28 9:03 ` [PATCH v5 1/3] printk: Export is_console_locked Hans de Goede
2018-06-28 9:03 ` [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable Hans de Goede
2018-07-11 14:46 ` Thomas Zimmermann
2018-07-11 14:52 ` Steven Rostedt
2018-07-11 15:01 ` Hans de Goede
2018-07-11 15:07 ` Daniel Vetter
2018-07-11 15:07 ` Thomas Zimmermann
2018-07-11 15:14 ` Hans de Goede
2018-07-11 15:28 ` Daniel Vetter
2018-07-11 15:35 ` Hans de Goede
2018-07-11 15:41 ` Steven Rostedt
2018-07-11 15:42 ` Daniel Vetter
2018-07-11 17:35 ` Hans de Goede
2018-07-11 17:56 ` Daniel Vetter
2018-07-11 19:19 ` Steven Rostedt [this message]
2018-07-11 19:41 ` Hans de Goede
2018-07-12 10:16 ` Thomas Zimmermann
2018-07-11 23:59 ` Sergey Senozhatsky
2018-06-28 9:03 ` [PATCH v5 3/3] console/fbcon: Add support for deferred console takeover Hans de Goede
2018-07-03 16:13 ` Sergey Senozhatsky
2018-07-03 16:14 ` Steven Rostedt
2018-07-03 16:36 ` Sergey Senozhatsky
2018-06-28 13:50 ` [PATCH v5 0/3] " Bartlomiej Zolnierkiewicz
2018-06-28 15:24 ` Hans de Goede
2018-06-28 22:44 ` Gustavo Padovan
2018-06-29 10:08 ` Bartlomiej Zolnierkiewicz
2018-06-29 12:51 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711151911.2ea40200@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=b.zolnierkie@samsung.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).