From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Daniel Vetter <daniel@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] console: Replace #if 1 with a bool to ignore WARN_CONSOLE_UNLOCKED()
Date: Thu, 12 Jul 2018 13:25:52 +0900 [thread overview]
Message-ID: <20180712042552.GB663@jagdpanzerIV> (raw)
In-Reply-To: <20180711230912.2575fae1@vmware.local.home>
On (07/11/18 23:09), Steven Rostedt wrote:
> > On (07/11/18 15:17), Steven Rostedt wrote:
> > > +bool ignore_console_lock_warning __read_mostly;
> > > +EXPORT_SYMBOL(ignore_console_lock_warning);
> >
> > OK. So, to recap,
> > We made is_console_locked() EXPORT_SYMBOL recently [it's still in linux-next],
> > so people could use WARN_CONSOLE_UNLOCKED in more places; this made other
> > people unhappy, so now we add another EXPORT_SYMBOL to the picture, which will
> > disable those newly added WARN_CONSOLE_UNLOCKED and make other people happy
> > again.
>
> Note, it only made people that added a module parameter that disables
> grabbing the console lock in the first place for debugging purposes
> only. The added WARN_CONSOLE_UNLOCKED() are good. Nobody complaining
> that they exist. They are complaining that it breaks one of their
> debugging work flows, and need to disable it when they are doing so.
True, but at the same time nobody complained that we didn't have those
extra WARN_CONSOLE_UNLOCKED()-s. Just saying. Over all I agree that there
is probably some value in those extra WARN-s.
> I could add a comment explaining why it exists. Something like:
>
> /*
> * Set this is you need to quiet WARN_CONSOLE_UNLOCKED() for debugging
> * purposes.
> */
s/is you/if you/
Suggested-by: One-of-those-commiters@YouKnowWhoYouAre.org ;)
-ss
next prev parent reply other threads:[~2018-07-12 4:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 19:17 [PATCH] console: Replace #if 1 with a bool to ignore WARN_CONSOLE_UNLOCKED() Steven Rostedt
2018-07-11 19:38 ` Hans de Goede
2018-07-12 1:58 ` Sergey Senozhatsky
2018-07-12 3:09 ` Steven Rostedt
2018-07-12 4:25 ` Sergey Senozhatsky [this message]
2018-07-12 7:53 ` Petr Mladek
2018-07-12 8:09 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712042552.GB663@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=daniel@ffwll.ch \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).