From: Aapo Vienamo <avienamo@nvidia.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v4 2/4] clk: tegra: refactor 7.1 div calculation
Date: Thu, 12 Jul 2018 10:44:16 +0300 [thread overview]
Message-ID: <20180712104416.7d2a6e14@dhcp-10-21-25-168> (raw)
In-Reply-To: <7022b1f4-97ac-aa1b-5c60-d7041da6704b@nvidia.com>
On Wed, 11 Jul 2018 16:14:13 +0100
Jon Hunter <jonathanh@nvidia.com> wrote:
> On 11/07/18 12:17, Peter De Schrijver wrote:
> > On Wed, Jul 11, 2018 at 09:42:20AM +0100, Jon Hunter wrote:
> >>
> >> On 11/07/18 09:00, Peter De Schrijver wrote:
> >>> On Tue, Jul 10, 2018 at 05:17:05PM +0100, Jon Hunter wrote:
> >>>>
> >>>> On 09/07/18 17:38, Aapo Vienamo wrote:
> >>>>> From: Peter De Schrijver <pdeschrijver@nvidia.com>
> >>>>>
> >>>>> Move this to a separate file so it can be used to calculate the sdmmc
> >>>>> clock dividers.
> >>>>
> >>>> Sorry for not commenting sooner, but what is the motivation for moving
> >>>> this to its own file? I don't see why we need to do this in order to use
> >>>> elsewhere. Furthermore, the original file is quite aptly named 'clk-divider.c'
> >>>> and now we have a div71.c which seems quite specific.
> >>>
> >>> How else would you do it?
> >>
> >> Keep it in the same file?
> >>
> >
> > That seems odd. clk-divider.c is meant to implement a clock type, not
> > utility functions we happen to need in several types.
>
> I see, then why not have a clk-utils.c for stuff like this. I am painting
> the bikeshed here, but div71.c seems very specific and I still don't
> understand the 7.1 bit.
While the code could work with other dividers, it was called 7.1 because
the current usecases were only on 7.1 dividers. I can submit another
version with a different filename if other changes to the series come
about or if it's seen necessary to change div-frac.c from the latest
version of the series to something else.
-Aapo
next prev parent reply other threads:[~2018-07-12 7:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 16:38 [PATCH v4 0/4] Multiplex sdmmc low jitter clock path Aapo Vienamo
2018-07-09 16:38 ` [PATCH v4 1/4] clk: tegra: Fix includes required by fence_udelay() Aapo Vienamo
2018-07-09 16:38 ` [PATCH v4 2/4] clk: tegra: refactor 7.1 div calculation Aapo Vienamo
2018-07-10 16:17 ` Jon Hunter
2018-07-11 8:00 ` Peter De Schrijver
2018-07-11 8:42 ` Jon Hunter
2018-07-11 11:17 ` Peter De Schrijver
2018-07-11 15:14 ` Jon Hunter
2018-07-12 7:44 ` Aapo Vienamo [this message]
2018-07-09 16:38 ` [PATCH v4 3/4] clk: tegra: Add sdmmc mux divider clock Aapo Vienamo
2018-07-09 16:38 ` [PATCH v4 4/4] clk: tegra: make sdmmc2 and sdmmc4 as sdmmc clocks Aapo Vienamo
2018-07-10 7:00 ` [PATCH v4 0/4] Multiplex sdmmc low jitter clock path Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712104416.7d2a6e14@dhcp-10-21-25-168 \
--to=avienamo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).