From: Michal Hocko <mhocko@kernel.org>
To: Chao Fan <fanc.fnst@cn.fujitsu.com>
Cc: Dou Liyang <douly.fnst@cn.fujitsu.com>,
Baoquan He <bhe@redhat.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
yasu.isimatu@gmail.com, keescook@chromium.org,
indou.takao@jp.fujitsu.com, caoj.fnst@cn.fujitsu.com,
vbabka@suse.cz, mgorman@techsingularity.net
Subject: Re: Bug report about KASLR and ZONE_MOVABLE
Date: Thu, 12 Jul 2018 14:32:28 +0200 [thread overview]
Message-ID: <20180712123228.GK32648@dhcp22.suse.cz> (raw)
In-Reply-To: <20180712060115.GD6742@localhost.localdomain>
On Thu 12-07-18 14:01:15, Chao Fan wrote:
> On Thu, Jul 12, 2018 at 01:49:49PM +0800, Dou Liyang wrote:
> >Hi Baoquan,
> >
> >At 07/11/2018 08:40 PM, Baoquan He wrote:
> >> Please try this v3 patch:
> >> >>From 9850d3de9c02e570dc7572069a9749a8add4c4c7 Mon Sep 17 00:00:00 2001
> >> From: Baoquan He <bhe@redhat.com>
> >> Date: Wed, 11 Jul 2018 20:31:51 +0800
> >> Subject: [PATCH v3] mm, page_alloc: find movable zone after kernel text
> >>
> >> In find_zone_movable_pfns_for_nodes(), when try to find the starting
> >> PFN movable zone begins in each node, kernel text position is not
> >> considered. KASLR may put kernel after which movable zone begins.
> >>
> >> Fix it by finding movable zone after kernel text on that node.
> >>
> >> Signed-off-by: Baoquan He <bhe@redhat.com>
> >
> >
> >You fix this in the _zone_init side_. This may make the 'kernelcore=' or
> >'movablecore=' failed if the KASLR puts the kernel back the tail of the
> >last node, or more.
>
> I think it may not fail.
> There is a 'restart' to do another pass.
>
> >
> >Due to we have fix the mirror memory in KASLR side, and Chao is trying
> >to fix the 'movable_node' in KASLR side. Have you had a chance to fix
> >this in the KASLR side.
> >
>
> I think it's better to fix here, but not KASLR side.
> Cause much more code will be change if doing it in KASLR side.
> Since we didn't parse 'kernelcore' in compressed code, and you can see
> the distribution of ZONE_MOVABLE need so much code, so we do not need
> to do so much job in KASLR side. But here, several lines will be OK.
I am not able to find the beginning of the email thread right now. Could
you summarize what is the actual problem please?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-07-12 12:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 9:42 Bug report about KASLR and ZONE_MOVABLE Chao Fan
2018-07-11 10:04 ` Chao Fan
2018-07-11 10:16 ` Chao Fan
2018-07-11 10:41 ` Baoquan He
2018-07-11 10:49 ` Baoquan He
2018-07-11 12:40 ` Baoquan He
2018-07-11 17:59 ` [PATCH v3] mm, page_alloc: find movable zone after kernel text kbuild test robot
2018-07-11 19:02 ` kbuild test robot
2018-07-12 1:19 ` Bug report about KASLR and ZONE_MOVABLE Chao Fan
2018-07-12 12:08 ` Baoquan He
2018-07-12 5:49 ` Dou Liyang
2018-07-12 6:01 ` Chao Fan
2018-07-12 12:32 ` Michal Hocko [this message]
2018-07-12 23:52 ` Baoquan He
2018-07-13 1:44 ` Chao Fan
2018-07-16 11:38 ` Michal Hocko
2018-07-16 13:02 ` Baoquan He
2018-07-16 15:24 ` Michal Hocko
2018-07-17 1:51 ` Baoquan He
2018-07-17 8:22 ` Michal Hocko
2018-07-11 12:41 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712123228.GK32648@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=indou.takao@jp.fujitsu.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).