From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dmitry Vyukov <dvyukov@google.com>,
Oleg Nesterov <oleg@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 0/2] Fix crash due to vma_is_anonymous() false-positives
Date: Thu, 12 Jul 2018 18:08:00 +0300 [thread overview]
Message-ID: <20180712150759.acjj4jdw4ykwvzwg@kshutemo-mobl1> (raw)
In-Reply-To: <20180712145626.41665-1-kirill.shutemov@linux.intel.com>
On Thu, Jul 12, 2018 at 05:56:24PM +0300, Kirill A. Shutemov wrote:
>
> Fix crash found by syzkaller.
>
> The fix allows to remove ->vm_ops checks.
>
> v2:
> - Catch few more cases where we need to initialize ->vm_ops:
> + nommu;
> + ia64;
> - Make sure that we initialize ->vm_ops even if ->mmap failed.
> We need ->vm_ops in error path too.
Just to be clear: it *should* help found issues, but I don't have setup to
test nommu changes.
And ion-related bug was actually caused by fault injection that failed
page allocation and ->mmap not setting ->vm_ops. It should be fine now.
But again I wasn't able to trigger the exact situation.
--
Kirill A. Shutemov
prev parent reply other threads:[~2018-07-12 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 14:56 [PATCHv2 0/2] Fix crash due to vma_is_anonymous() false-positives Kirill A. Shutemov
2018-07-12 14:56 ` [PATCHv2 1/2] mm: Fix " Kirill A. Shutemov
2018-07-12 16:20 ` Oleg Nesterov
2018-07-12 16:39 ` Kirill A. Shutemov
2018-07-12 14:56 ` [PATCHv2 2/2] mm: Drop unneeded ->vm_ops checks Kirill A. Shutemov
2018-07-16 13:30 ` REGRESSION: " Marcel Ziswiler
2018-07-16 14:20 ` Kirill A. Shutemov
2018-07-16 16:09 ` Marcel Ziswiler
2018-07-16 16:57 ` Kirill A. Shutemov
2018-07-12 15:08 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712150759.acjj4jdw4ykwvzwg@kshutemo-mobl1 \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).