From: David Miller <davem@davemloft.net>
To: gregory.clement@bootlin.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
thomas.petazzoni@bootlin.com,
linux-arm-kernel@lists.infradead.org, jason@lakedaemon.net,
andrew@lunn.ch, sebastian.hesselbarth@gmail.com,
yelena@marvell.com, nadavh@marvell.com, mw@semihalf.com,
dima@marvell.com, antoine.tenart@bootlin.com,
miquel.raynal@bootlin.com, maxime.chevallier@bootlin.com
Subject: Re: [PATCH net-next v2 5/7] net: mvneta: Allocate page for the descriptor
Date: Fri, 13 Jul 2018 18:23:11 -0700 (PDT) [thread overview]
Message-ID: <20180713.182311.1329076241299839709.davem@davemloft.net> (raw)
In-Reply-To: <20180713161841.11202-6-gregory.clement@bootlin.com>
From: Gregory CLEMENT <gregory.clement@bootlin.com>
Date: Fri, 13 Jul 2018 18:18:39 +0200
> -static int mvneta_rx_refill(struct mvneta_port *pp,
> - struct mvneta_rx_desc *rx_desc,
> - struct mvneta_rx_queue *rxq)
> -
> +/* Allocate page per descriptor */
> +static inline int mvneta_rx_refill(struct mvneta_port *pp,
> + struct mvneta_rx_desc *rx_desc,
Please do not use inline functions in foo.c files, let the compiler
decide.
Thank you.
next prev parent reply other threads:[~2018-07-14 1:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 16:18 [PATCH net-next v2 0/7] A fix and a few improvements on mvneta Gregory CLEMENT
2018-07-13 16:18 ` [PATCH net-next v2 1/7] net: ethernet: mvneta: Fix napi structure mixup on armada 3700 Gregory CLEMENT
2018-07-13 16:18 ` [PATCH net-next v2 2/7] net: mvneta: remove data pointer usage from device_node structure Gregory CLEMENT
2018-07-13 16:18 ` [PATCH net-next v2 3/7] net: mvneta: increase number of buffers in RX and TX queue Gregory CLEMENT
2018-07-13 19:17 ` Russell King - ARM Linux
2018-07-18 15:37 ` Gregory CLEMENT
2018-07-18 20:55 ` Dave Taht
2018-07-13 16:18 ` [PATCH net-next v2 4/7] net: mvneta: discriminate error cause for missed packet Gregory CLEMENT
2018-07-13 16:18 ` [PATCH net-next v2 5/7] net: mvneta: Allocate page for the descriptor Gregory CLEMENT
2018-07-14 1:23 ` David Miller [this message]
2018-07-13 16:18 ` [PATCH net-next v2 6/7] net: mvneta: Verify hardware checksum only when offload checksum feature is set Gregory CLEMENT
2018-07-13 16:18 ` [PATCH net-next v2 7/7] net: mvneta: Improve the buffer allocation method for SWBM Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713.182311.1329076241299839709.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=dima@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yelena@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).