On Fri, Jul 13, 2018 at 10:28:08AM +0800, Icenowy Zheng wrote:
> 
> 
> 于 2018年7月12日 GMT+08:00 下午10:53:06, Maxime Ripard <maxime.ripard@bootlin.com> 写到:
> >On Thu, Jul 12, 2018 at 03:09:55PM +0800, Icenowy Zheng wrote:
> >> 于 2018年7月12日 GMT+08:00 下午2:46:01, Maxime Ripard
> ><maxime.ripard@bootlin.com> 写到:
> >> >On Wed, Jul 11, 2018 at 11:15:50PM +0800, Icenowy Zheng wrote:
> >> >> 
> >> >> 
> >> >> 于 2018年7月11日 GMT+08:00 下午11:05:32, Maxime Ripard
> >> ><maxime.ripard@bootlin.com> 写到:
> >> >> >Hi,
> >> >> >
> >> >> >On Wed, Jul 11, 2018 at 09:22:32PM +0800, Icenowy Zheng wrote:
> >> >> >> Banana Pi M2 Zero board has a miniHDMI port connected to the
> >HDMI
> >> >> >> controller of Allwinner H3 SoC.
> >> >> >> 
> >> >> >> Enable the HDMI output in Banana Pi M2 Zero device tree.
> >> >> >> 
> >> >> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> >> >> >> ---
> >> >> >>  .../dts/sun8i-h2-plus-bananapi-m2-zero.dts    | 25
> >> >> >+++++++++++++++++++
> >> >> >>  1 file changed, 25 insertions(+)
> >> >> >> 
> >> >> >> diff --git
> >a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> >b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> >> index 7d01f9322658..eb61dcf32797 100644
> >> >> >> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> >> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> >> >> >> @@ -26,6 +26,17 @@
> >> >> >>  		stdout-path = "serial0:115200n8";
> >> >> >>  	};
> >> >> >>  
> >> >> >> +	hdmi-connector {
> >> >> >> +		compatible = "hdmi-connector";
> >> >> >> +		type = "c";
> >> >> >
> >> >> >This is not one of the connector type declared in DRM, how is it
> >> >> >exposed to the userspace?
> >> >> 
> >> >> So just use "A" here (because of single link)?
> >> >
> >> >If the connector type is C, it should be C, and DRM / driver
> >adjusted
> >> >to handle it.
> >> 
> >> Okay I won't change this property, if there's any further revisions.
> >> 
> >> For DRM driver, I think it can be an independent patchset.
> >
> >Not really, since it's going to break userspace as soon as you merge
> >that other patchset.
> 
> Should we bother the DRM maintainer to ask for any advice?

You can if you want.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com