linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Okash Khawaja <osk@fb.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
	Martin KaFai Lau <kafai@fb.com>,
	Alexei Starovoitov <ast@kernel.org>, Yonghong Song <yhs@fb.com>,
	Quentin Monnet <quentin.monnet@netronome.com>,
	"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<kernel-team@fb.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v5 0/3] bpf: btf: print bpftool map data with btf
Date: Fri, 13 Jul 2018 23:43:26 +0100	[thread overview]
Message-ID: <20180713224326.GA5941@w1t1fb> (raw)
In-Reply-To: <1e80f262-9b3f-e4ff-0e89-7a07098d1b50@iogearbox.net>

On Sat, Jul 14, 2018 at 12:35:03AM +0200, Daniel Borkmann wrote:
> On 07/13/2018 11:35 PM, Okash Khawaja wrote:
> > On Fri, Jul 13, 2018 at 10:49:01PM +0200, Daniel Borkmann wrote:
> >> On 07/12/2018 05:30 AM, Jakub Kicinski wrote:
> >>> On Wed, 11 Jul 2018 20:08:03 -0700, Okash Khawaja wrote:
> >>>> Hi,
> >>>>
> >>>> Here are the changes from v4:
> >>>>
> >>>> patch 2:
> >>>>
> >>>> - sort headers in btf_dumper.c
> >>>> - remove extra parentheses
> >>>> - include asm/byteorder.h
> >>>> - compile error when big and small endian bitfields macro undefined
> >>>
> >>> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> >>
> >> Hmm, strange, by accident I just noticed that only your bpf fix ever made
> >> it to patchwork, Okash.
> >>
> >>   https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_project_netdev_list_-3Fsubmitter-3D74458-26state-3D-2A&d=DwICaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=4wHrS7MHHFLZe_WCJwRVhA&m=wkiBQFYWPyiN9WONHLY0WiZxcOwNRhXaMMLIE551mCA&s=RggQzClRdkwawboGLPgPXHOdUtYffxeOwlcBlFru-P4&e=
> >>
> >> Potentially because you've sent with attachments which got dropped on
> >> the list?
> > interesting because i send all patches using quilt mail, the same way i
> > sent bpf fix. i can try git-send-email.
> > 
> > also i dropped Acked-by as i changed patch versions. is it common thing
> > to do? or should i keep the Acked-by?
> 
> Depends on whether the pieces that have been ACKed changed in the
> meantime or not.
right, thanks. makes sense :)

regarding patches not showing in patchwork, i've checked that the
patches are not attachments. is it going to be a problem with
upstreaming if they don't show up in patchwork? should i send patches
again?

  reply	other threads:[~2018-07-13 22:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12  3:08 [PATCH bpf-next v5 0/3] bpf: btf: print bpftool map data with btf Okash Khawaja
2018-07-12  3:08 ` [PATCH bpf-next v5 2/3] bpf: btf: add btf print functionality Okash Khawaja
2018-07-12  3:08 ` [PATCH bpf-next v5 3/3] bpf: btf: print map dump and lookup with btf info Okash Khawaja
2018-07-12  3:30 ` [PATCH bpf-next v5 0/3] bpf: btf: print bpftool map data with btf Jakub Kicinski
2018-07-13 20:49   ` Daniel Borkmann
2018-07-13 21:35     ` Okash Khawaja
2018-07-13 22:35       ` Daniel Borkmann
2018-07-13 22:43         ` Okash Khawaja [this message]
2018-07-14  4:57 Okash Khawaja
2018-07-14 11:03 ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180713224326.GA5941@w1t1fb \
    --to=osk@fb.com \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=jakub.kicinski@netronome.com \
    --cc=kafai@fb.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=quentin.monnet@netronome.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).