From: Viresh Kumar <viresh.kumar@linaro.org>
To: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
robh@kernel.org
Cc: linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
devicetree@vger.kernel.org, olof@lixom.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: thermal: Allow multiple devices to share cooling map
Date: Mon, 16 Jul 2018 10:04:01 +0530 [thread overview]
Message-ID: <20180716043401.aew5yjmxjfamfqtn@vireshk-i7> (raw)
In-Reply-To: <bdd735da9a3c8159756b084ca96b555437057fa4.1530766981.git.viresh.kumar@linaro.org>
On 05-07-18, 10:39, Viresh Kumar wrote:
> Allow cooling devices sharing same trip point with same contribution
> value to share the cooling map as well. Otherwise the same information
> will be duplicated for each device sharing the trip point.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Documentation/devicetree/bindings/thermal/thermal.txt | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
> index cc553f0952c5..eb7ee91556a5 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
> @@ -97,8 +97,8 @@ get assigned to trip points of the zone. The cooling devices are expected
> to be loaded in the target system.
>
> Required properties:
> -- cooling-device: A phandle of a cooling device with its specifier,
> - Type: phandle + referring to which cooling device is used in this
> +- cooling-device: A list of phandles of cooling devices with their specifiers,
> + Type: phandle + referring to which cooling devices are used in this
> cooling specifier binding. In the cooling specifier, the first cell
> is the minimum cooling state and the second cell
> is the maximum cooling state used in this map.
> @@ -276,12 +276,7 @@ thermal-zones {
> };
> map1 {
> trip = <&cpu_alert1>;
> - cooling-device = <&fan0 5 THERMAL_NO_LIMIT>;
> - };
> - map2 {
> - trip = <&cpu_alert1>;
> - cooling-device =
> - <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + cooling-device = <&fan0 5 THERMAL_NO_LIMIT>, <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> };
> };
> };
Any objections to this ? Can you guys provide Acks ?
--
viresh
next prev parent reply other threads:[~2018-07-16 4:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 5:09 [PATCH 0/2] dt: thermal: Fix broken cooling-maps Viresh Kumar
2018-07-05 5:09 ` [PATCH 1/2] dt-bindings: thermal: Allow multiple devices to share cooling map Viresh Kumar
2018-07-16 4:34 ` Viresh Kumar [this message]
2018-07-16 22:02 ` Rob Herring
2018-07-05 5:09 ` [PATCH 2/2] arm64: dts: hi6220: Add all CPUs in cooling maps Viresh Kumar
2018-07-05 8:44 ` Daniel Lezcano
2018-07-17 10:54 ` [PATCH] of: thermal: Allow multiple devices to share cooling map Viresh Kumar
2018-08-06 18:05 ` Eduardo Valentin
2018-08-08 7:08 ` [PATCH V2] " Viresh Kumar
2018-08-24 23:14 ` Eduardo Valentin
2018-07-18 15:34 ` [PATCH 0/2] dt: thermal: Fix broken cooling-maps Wei Xu
2018-07-19 2:40 ` Viresh Kumar
2018-07-19 9:54 ` Wei Xu
2018-07-31 4:51 ` Viresh Kumar
2018-07-31 6:00 ` Zhang Rui
2018-08-03 8:40 ` Viresh Kumar
2018-08-06 6:29 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716043401.aew5yjmxjfamfqtn@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).