From: Marco Felsch <m.felsch@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
fabio.estevam@nxp.com, Anson.Huang@nxp.com,
kernel@pengutronix.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: pfuze100: add optional disable switch-regulators binding
Date: Mon, 16 Jul 2018 09:25:16 +0200 [thread overview]
Message-ID: <20180716072516.bvsp54yoeqp3ih6s@pengutronix.de> (raw)
In-Reply-To: <20180713150314.GD16228@sirena.org.uk>
Hi Mark,
thanks for the review.
On 18-07-13 16:03, Mark Brown wrote:
> On Fri, Jul 13, 2018 at 02:50:01PM +0200, Marco Felsch wrote:
>
> > +Optional properties:
> > +- fsl,pfuze-support-disable: Boolean, if present disable all unused switch
> > + regulators to save power consumption. Attention, till 4.18 these regulators
>
> The property name sounds like it affects all the regulators but really
> it's just the sw ones - how about adding -sw at the end? Bit of a
> bikeshed but it does end up in an ABI.
You're right, it sounds better. So the new binding will be
fsl,pfuze-support-disable-sw. Are there any other comments about the
implementation?
Regards,
Marco
next prev parent reply other threads:[~2018-07-16 7:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 12:50 [PATCH v2 0/2] Re-Enable support to disable switch regulators Marco Felsch
2018-07-13 12:50 ` [PATCH v2 1/3] dt-bindings: pfuze100: add optional disable switch-regulators binding Marco Felsch
2018-07-13 15:03 ` Mark Brown
2018-07-16 7:25 ` Marco Felsch [this message]
2018-07-18 12:09 ` Mark Brown
2018-07-16 17:55 ` Rob Herring
2018-07-18 14:58 ` Marco Felsch
2018-07-13 12:50 ` [PATCH v2 2/3] regulator: pfuze100: add support to en-/disable switch regulators Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716072516.bvsp54yoeqp3ih6s@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=Anson.Huang@nxp.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).