linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: Miroslav Benes <mbenes@suse.cz>, Jiri Kosina <jkosina@suse.cz>,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] livepatch: Remove reliable stacktrace check in klp_try_switch_task()
Date: Mon, 16 Jul 2018 07:40:13 -0500	[thread overview]
Message-ID: <20180716124013.uiyyzr3wabgdshea@treble> (raw)
In-Reply-To: <dbd9bdf6-7cb1-cde1-5f7d-d3a5449c560d@linux.vnet.ibm.com>

On Sun, Jul 15, 2018 at 01:05:56PM +0530, Kamalesh Babulal wrote:
> On Saturday 14 July 2018 12:07 AM, Josh Poimboeuf wrote:
> > > We bail out during patch registration for architectures, those don't
> > > support reliable stack trace.
> > 
> > Does anybody know if that change was intentional?  I thought the plan
> > was to allow non-consistency-model arches to still use livepatch, and
> > that they'd just have to 'force' patches to completion instead.  That
> > seems a little more forgiving.
> > 
> 
> The initial proposal was to allow 'force' feature on architectures
> without HAVE_RELIABLE_STACKTRACE support and use pr_notice() to warn
> user about the non-availability of consistency model. It was argued
> against, as it will encourage people to use it as an alternative instead
> of adding HAVE_RELIABLE_STACKTRACE support to the kernel.

Ok, looking through the archives, I found it:

  https://lkml.kernel.org/r/20171221151428.rt4dlizxb5nqhb3h@pathway.suse.cz

I'm not sure I agree with that conclusion, but nobody has complained
about it, so it's probably fine...

-- 
Josh

  reply	other threads:[~2018-07-16 12:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12  8:05 [PATCH] livepatch: Remove reliable stacktrace check in klp_try_switch_task() Kamalesh Babulal
2018-07-12  8:34 ` Petr Mladek
2018-07-12  9:15 ` Miroslav Benes
2018-07-13 18:37 ` Josh Poimboeuf
2018-07-15  7:35   ` Kamalesh Babulal
2018-07-16 12:40     ` Josh Poimboeuf [this message]
2018-07-16 12:41 ` Josh Poimboeuf
2018-07-16 15:51 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180716124013.uiyyzr3wabgdshea@treble \
    --to=jpoimboe@redhat.com \
    --cc=jkosina@suse.cz \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).