From: Pavel Machek <pavel@ucw.cz>
To: David Lechner <david@lechnology.com>
Cc: Baolin Wang <baolin.wang@linaro.org>,
jacek.anaszewski@gmail.com, bjorn.andersson@linaro.org,
broonie@kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] leds: core: Introduce generic pattern interface
Date: Mon, 16 Jul 2018 23:43:54 +0200 [thread overview]
Message-ID: <20180716214354.GA10734@amd> (raw)
In-Reply-To: <6ecb22d5-fac4-dbe9-87e7-196d87d6d06f@lechnology.com>
[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]
On Mon 2018-07-16 11:51:01, David Lechner wrote:
> On 07/16/2018 06:10 AM, Baolin Wang wrote:
> >From: Bjorn Andersson <bjorn.andersson@linaro.org>
> >
> >Some LED controllers have support for autonomously controlling
> >brightness over time, according to some preprogrammed pattern or
> >function.
> >
> >This adds a new optional operator that LED class drivers can implement
> >if they support such functionality as well as a new device attribute to
> >configure the pattern for a given LED.
> >
>
> Hmm... I was hoping that this would be a generic pattern trigger that
> could be used by any LED (e.g. gpio LEDs), not just LEDs with hardware
> support. I guess I cannot really test this after all.
>
> I think it looks good for your use case though.
Generic trigger doing patterns on any hardware would be welcome, too.
I even have a copy of code somewhere, if you want to dust it off,
clean up and merge...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-07-16 21:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 11:10 [PATCH v5 1/2] leds: core: Introduce generic pattern interface Baolin Wang
2018-07-16 11:10 ` [PATCH v5 2/2] leds: sc27xx: Add pattern_set/get/clear interfaces for LED controller Baolin Wang
2018-07-16 16:51 ` [PATCH v5 1/2] leds: core: Introduce generic pattern interface David Lechner
2018-07-16 21:43 ` Pavel Machek [this message]
2018-07-24 1:06 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716214354.GA10734@amd \
--to=pavel@ucw.cz \
--cc=baolin.wang@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=david@lechnology.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).