From: Chao Fan <fanc.fnst@cn.fujitsu.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <x86@kernel.org>, <hpa@zytor.com>,
<tglx@linutronix.de>, <mingo@redhat.com>, <bhe@redhat.com>,
<keescook@chromium.org>, <yasu.isimatu@gmail.com>,
<indou.takao@jp.fujitsu.com>, <lcapitulino@redhat.com>,
<caoj.fnst@cn.fujitsu.com>, <douly.fnst@cn.fujitsu.com>
Subject: Re: [RFC PATCH v2 3/4] x86/boot/KASLR: Walk srat tables to filter immovable memory
Date: Tue, 17 Jul 2018 09:01:33 +0800 [thread overview]
Message-ID: <20180717010132.GA6816@localhost.localdomain> (raw)
In-Reply-To: <20180716114447.GA7650@gmail.com>
On Mon, Jul 16, 2018 at 01:44:47PM +0200, Ingo Molnar wrote:
>
>* Chao Fan <fanc.fnst@cn.fujitsu.com> wrote:
>
>> If 'CONFIG_MEMORY_HOTREMOVE' specified, walk the acpi srat memory
>> tables, store the immovable memory regions, so that kaslr can get
>> the information abouth where can be selected or not.
>> If 'CONFIG_MEMORY_HOTREMOVE' not specified, go on the old code.
>>
>> Signed-off-by: Chao Fan <fanc.fnst@cn.fujitsu.com>
>> ---
>> arch/x86/boot/compressed/kaslr.c | 55 ++++++++++++++++++++++++++++++++
>> 1 file changed, 55 insertions(+)
>>
>> diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
>> index 531c9876f573..0ec5aab915db 100644
>> --- a/arch/x86/boot/compressed/kaslr.c
>> +++ b/arch/x86/boot/compressed/kaslr.c
>> @@ -31,6 +31,7 @@
>>
>> #include "misc.h"
>> #include "error.h"
>> +#include "acpitb.h"
>> #include "../string.h"
>>
>> #include <generated/compile.h>
>> @@ -104,6 +105,14 @@ static bool memmap_too_large;
>> /* Store memory limit specified by "mem=nn[KMG]" or "memmap=nn[KMG]" */
>> unsigned long long mem_limit = ULLONG_MAX;
>>
>> +#ifdef CONFIG_MEMORY_HOTREMOVE
>> +/* Store the movable memory */
>> +struct mem_vector immovable_mem[MAX_NUMNODES*2];
>> +
>> +/* Store the num of movable mem regions */
>> +static int num_immovable_mem;
>> +#endif
>
>So comment says 'movable', but variables are named 'immovable'??
Sorry for the typo, will change it immidiately.
Thanks,
Chao Fan
>
>Thanks,
>
> Ingo
>
>
next prev parent reply other threads:[~2018-07-17 1:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 8:55 [RFC PATCH v2 0/4] x86/boot/KASLR: Parse ACPI table and limit kaslr in immovable memory Chao Fan
2018-07-16 8:55 ` [RFC PATCH v2 1/4] x86/boot: Add acpitb.h to help parse acpi tables Chao Fan
2018-07-16 8:55 ` [RFC PATCH v2 2/4] x86/boot: Add acpitb.c to " Chao Fan
2018-07-16 8:55 ` [RFC PATCH v2 3/4] x86/boot/KASLR: Walk srat tables to filter immovable memory Chao Fan
2018-07-16 11:44 ` Ingo Molnar
2018-07-17 1:01 ` Chao Fan [this message]
2018-07-16 8:55 ` [RFC PATCH v2 4/4] x86/boot/KASLR: Limit kaslr to choosing the " Chao Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717010132.GA6816@localhost.localdomain \
--to=fanc.fnst@cn.fujitsu.com \
--cc=bhe@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=indou.takao@jp.fujitsu.com \
--cc=keescook@chromium.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).