From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH rcu] rcutorture: err_segs_recorded can be static
Date: Mon, 16 Jul 2018 21:03:46 -0700 [thread overview]
Message-ID: <20180717040346.GE12945@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180717014452.GA49087@lkp-g5>
On Tue, Jul 17, 2018 at 09:44:52AM +0800, kbuild test robot wrote:
>
> Fixes: 07809ecaa895 ("rcutorture: Dump reader protection sequence if failures or close calls")
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
Good catch! I have folded this in with attribution.
Thanx, Paul
> ---
> rcutorture.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index ef85bde..a7a947e 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -209,9 +209,9 @@ struct rt_read_seg {
> unsigned long rt_delay_us;
> bool rt_preempted;
> };
> -int err_segs_recorded;
> -struct rt_read_seg err_segs[RCUTORTURE_RDR_MAX_SEGS];
> -int rt_read_nsegs;
> +static int err_segs_recorded;
> +static struct rt_read_seg err_segs[RCUTORTURE_RDR_MAX_SEGS];
> +static int rt_read_nsegs;
>
> static const char *rcu_torture_writer_state_getname(void)
> {
>
prev parent reply other threads:[~2018-07-17 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 1:44 [rcu:dev 211/211] kernel/rcu/rcutorture.c:212:5: sparse: symbol 'err_segs_recorded' was not declared. Should it be static? kbuild test robot
2018-07-17 1:44 ` [RFC PATCH rcu] rcutorture: err_segs_recorded can be static kbuild test robot
2018-07-17 4:03 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717040346.GE12945@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).