linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org,
	Antoine Tenart <antoine.tenart@bootlin.com>,
	kbuild test robot <fengguang.wu@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next] net: mvpp2: mvpp2_flow_get_hek_fields() can be static
Date: Tue, 17 Jul 2018 09:38:01 +0200	[thread overview]
Message-ID: <20180717093801.6bddd5b5@bootlin.com> (raw)
In-Reply-To: <20180717011812.GZ10593@intel.com>

Hi,

On Tue, 17 Jul 2018 09:18:12 +0800
kbuild test robot <lkp@intel.com> wrote:

>Fixes: d33ec4525007 ("net: mvpp2: add an RSS classification step for each flow")
>Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
>---
> mvpp2_cls.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
>index 723d0ba..fc9ec51 100644
>--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
>+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
>@@ -618,7 +618,7 @@ static int mvpp2_port_rss_hash_opts_set(struct mvpp2_port *port, int flow_type,
> 	return 0;
> }
> 
>-u16 mvpp2_flow_get_hek_fields(struct mvpp2_cls_flow_entry *fe)
>+static u16 mvpp2_flow_get_hek_fields(struct mvpp2_cls_flow_entry *fe)
> {
> 	u16 hash_opts = 0;
> 	int n_fields, i, field;

That was a valid patch since it seems I forgot to make
another function static in the RSS series.

However this function is used in debugfs, so this patch isn't valid
anymore.

Sorry about that, but please don't apply this.

Thanks,

Maxime

-- 
Maxime Chevallier, Bootlin (formerly Free Electrons)
Embedded Linux and kernel engineering
https://bootlin.com

      reply	other threads:[~2018-07-17  7:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201807141506.hlrwYth1%fengguang.wu@intel.com>
2018-07-17  1:18 ` [RFC PATCH net-next] net: mvpp2: mvpp2_flow_get_hek_fields() can be static kbuild test robot
2018-07-17  7:38   ` Maxime Chevallier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180717093801.6bddd5b5@bootlin.com \
    --to=maxime.chevallier@bootlin.com \
    --cc=antoine.tenart@bootlin.com \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).