From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Marek Vasut <marek.vasut+renesas@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] regulator: bd9571mwv: Use "backup_mode" sysfs file instead of "wake_up"
Date: Tue, 17 Jul 2018 13:36:30 +0200 [thread overview]
Message-ID: <20180717113630.GF10087@bigcity.dyn.berto.se> (raw)
In-Reply-To: <20180716153052.1830-2-geert+renesas@glider.be>
Hi Geert,
Thanks for your patch.
On 2018-07-16 17:30:50 +0200, Geert Uytterhoeven wrote:
> Currently the BD9571MWV PMIC driver uses the standard "wake_up" sysfs
> file to control enablement of DDR Backup Mode.
>
> However, configuring DDR Backup Mode is not really equivalent to
> configuring the PMIC as a wake-up source. To avoid confusion, use a
> custom "backup_mode" attribute file in sysfs instead.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> v4:
> - Fix build error and warning if !CONFIG_PM_SLEEP,
>
> v3:
> - New.
> ---
> drivers/regulator/bd9571mwv-regulator.c | 52 ++++++++++++++++++++++---
> 1 file changed, 47 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c
> index be574eb444ebda97..1da36a6590c84ba4 100644
> --- a/drivers/regulator/bd9571mwv-regulator.c
> +++ b/drivers/regulator/bd9571mwv-regulator.c
> @@ -30,6 +30,7 @@ struct bd9571mwv_reg {
> /* DDR Backup Power */
> u8 bkup_mode_cnt_keepon; /* from "rohm,ddr-backup-power" */
> u8 bkup_mode_cnt_saved;
> + bool bkup_mode_enabled;
>
> /* Power switch type */
> bool rstbmode_level;
> @@ -171,13 +172,40 @@ static int bd9571mwv_bkup_mode_write(struct bd9571mwv *bd, unsigned int mode)
> return 0;
> }
>
> +static ssize_t backup_mode_show(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + struct bd9571mwv_reg *bdreg = dev_get_drvdata(dev);
> +
> + return sprintf(buf, "%s\n", bdreg->bkup_mode_enabled ? "on" : "off");
> +}
> +
> +static ssize_t backup_mode_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + struct bd9571mwv_reg *bdreg = dev_get_drvdata(dev);
> + int ret;
> +
> + if (!count)
> + return 0;
> +
> + ret = kstrtobool(buf, &bdreg->bkup_mode_enabled);
> + if (ret)
> + return ret;
> +
> + return count;
> +}
> +
> +DEVICE_ATTR_RW(backup_mode);
> +
> static int bd9571mwv_suspend(struct device *dev)
> {
> struct bd9571mwv_reg *bdreg = dev_get_drvdata(dev);
> unsigned int mode;
> int ret;
>
> - if (!device_may_wakeup(dev))
> + if (!bdreg->bkup_mode_enabled)
> return 0;
>
> /* Save DDR Backup Mode */
> @@ -204,7 +232,7 @@ static int bd9571mwv_resume(struct device *dev)
> {
> struct bd9571mwv_reg *bdreg = dev_get_drvdata(dev);
>
> - if (!device_may_wakeup(dev))
> + if (!bdreg->bkup_mode_enabled)
> return 0;
>
> /* Restore DDR Backup Mode */
> @@ -215,9 +243,15 @@ static const struct dev_pm_ops bd9571mwv_pm = {
> SET_SYSTEM_SLEEP_PM_OPS(bd9571mwv_suspend, bd9571mwv_resume)
> };
>
> +static int bd9571mwv_regulator_remove(struct platform_device *pdev)
> +{
> + device_remove_file(&pdev->dev, &dev_attr_backup_mode);
> + return 0;
> +}
> #define DEV_PM_OPS &bd9571mwv_pm
> #else
> #define DEV_PM_OPS NULL
> +#define bd9571mwv_regulator_remove NULL
> #endif /* CONFIG_PM_SLEEP */
>
> static int bd9571mwv_regulator_probe(struct platform_device *pdev)
> @@ -270,14 +304,21 @@ static int bd9571mwv_regulator_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> +#ifdef CONFIG_PM_SLEEP
> if (bdreg->bkup_mode_cnt_keepon) {
> - device_set_wakeup_capable(&pdev->dev, true);
> + int ret;
> +
> /*
> - * Wakeup is enabled by default in pulse mode, but needs
> + * Backup mode is enabled by default in pulse mode, but needs
> * explicit user setup in level mode.
> */
> - device_set_wakeup_enable(&pdev->dev, bdreg->rstbmode_pulse);
> + bdreg->bkup_mode_enabled = bdreg->rstbmode_pulse;
> +
> + ret = device_create_file(&pdev->dev, &dev_attr_backup_mode);
> + if (ret)
> + return ret;
> }
> +#endif /* CONFIG_PM_SLEEP */
>
> return 0;
> }
> @@ -294,6 +335,7 @@ static struct platform_driver bd9571mwv_regulator_driver = {
> .pm = DEV_PM_OPS,
> },
> .probe = bd9571mwv_regulator_probe,
> + .remove = bd9571mwv_regulator_remove,
> .id_table = bd9571mwv_regulator_id_table,
> };
> module_platform_driver(bd9571mwv_regulator_driver);
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2018-07-17 11:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 15:30 [PATCH v4 0/3] regulator: bd9571mwv: Add support for toggle power switches Geert Uytterhoeven
2018-07-16 15:30 ` [PATCH v4 1/3] regulator: bd9571mwv: Use "backup_mode" sysfs file instead of "wake_up" Geert Uytterhoeven
2018-07-17 11:36 ` Niklas Söderlund [this message]
2018-07-18 12:29 ` Applied "regulator: bd9571mwv: Use "backup_mode" sysfs file instead of "wake_up"" to the regulator tree Mark Brown
2018-07-16 15:30 ` [PATCH v4 2/3] regulator: bd9571mwv: Add support for toggle power switches Geert Uytterhoeven
2018-07-17 11:49 ` Niklas Söderlund
2018-07-18 12:29 ` Applied "regulator: bd9571mwv: Add support for toggle power switches" to the regulator tree Mark Brown
2018-07-16 15:30 ` [PATCH v4 3/3] regulator: bd9571mwv: Document "backup_mode" sysfs file Geert Uytterhoeven
2018-07-17 11:53 ` Niklas Söderlund
2018-07-18 12:29 ` Applied "regulator: bd9571mwv: Document "backup_mode" sysfs file" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717113630.GF10087@bigcity.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=len.brown@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).