From: Christoph Hellwig <hch@infradead.org>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org,
okaya@codeaurora.org, chenhc@lemote.com,
Sergey.Semin@t-platforms.ru, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method
Date: Tue, 17 Jul 2018 05:48:18 -0700 [thread overview]
Message-ID: <20180717124818.GC22099@infradead.org> (raw)
In-Reply-To: <20180711135210.GA18730@mobilestation>
On Wed, Jul 11, 2018 at 04:52:10PM +0300, Serge Semin wrote:
> Hello Christoph,
>
> On Tue, Jul 10, 2018 at 11:56:31PM -0700, Christoph Hellwig <hch@infradead.org> wrote:
> > > + * This is a MIPS specific ioremap variant. ioremap_cacheable_cow
> > > + * requests a cachable mapping with CWB attribute enabled.
> > > */
> > > #define ioremap_cacheable_cow(offset, size) \
> > > __ioremap_mode((offset), (size), _CACHE_CACHABLE_COW)
> >
> > This isn't actually used anywhere in the kernel tree. Please remove it
> > as well.
>
> I don't really know whether it is necessary at this point. We discarded the
> ioremap_uncached_accelerated() method, since the obvious alternative is now
> available: ioremap_wc(). While ioremap_cacheable_cow() hasn't got one.
> So if it was up to me, I'd leave it here. Anyway if the subsystem maintainers
> think otherwise, I won't refuse to submit a patch with this method removal.
The function is entirely unused in the kernel tree, please remove it.
prev parent reply other threads:[~2018-07-17 12:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 13:57 [PATCH 1/2] mips: mm: Create UCA-based ioremap_wc() method Serge Semin
2018-07-09 13:57 ` [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated() method Serge Semin
2018-07-10 7:15 ` Mathieu Malaterre
2018-07-10 7:48 ` Serge Semin
2018-07-10 17:59 ` Paul Burton
2018-07-10 19:13 ` Serge Semin
2018-07-10 21:04 ` Paul Burton
2018-07-11 8:27 ` Serge Semin
2018-07-11 6:56 ` Christoph Hellwig
2018-07-11 13:52 ` Serge Semin
2018-07-17 12:48 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717124818.GC22099@infradead.org \
--to=hch@infradead.org \
--cc=Sergey.Semin@t-platforms.ru \
--cc=chenhc@lemote.com \
--cc=fancer.lancer@gmail.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=okaya@codeaurora.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).