From: Stefan Hajnoczi <stefanha@redhat.com>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
qemu-devel@nongnu.org, linux-nvdimm@ml01.01.org, jack@suse.cz,
dan.j.williams@intel.com, riel@surriel.com,
haozhong.zhang@intel.com, nilal@redhat.com, kwolf@redhat.com,
pbonzini@redhat.com, ross.zwisler@intel.com, david@redhat.com,
xiaoguangrong.eric@gmail.com, hch@infradead.org, mst@redhat.com,
niteshnarayanlal@hotmail.com, lcapitulino@redhat.com,
imammedo@redhat.com, eblake@redhat.com
Subject: Re: [RFC v3 2/2] virtio-pmem: Add virtio pmem driver
Date: Tue, 17 Jul 2018 14:11:56 +0100 [thread overview]
Message-ID: <20180717131156.GA13498@stefanha-x1.localdomain> (raw)
In-Reply-To: <20180713075232.9575-3-pagupta@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2028 bytes --]
On Fri, Jul 13, 2018 at 01:22:31PM +0530, Pankaj Gupta wrote:
> + /* The request submission function */
> +static int virtio_pmem_flush(struct device *dev)
> +{
> + int err;
> + unsigned long flags;
> + struct scatterlist *sgs[2], sg, ret;
> + struct virtio_device *vdev = dev_to_virtio(dev->parent->parent);
> + struct virtio_pmem *vpmem = vdev->priv;
> + struct virtio_pmem_request *req = kmalloc(sizeof(*req), GFP_KERNEL);
> +
> + req->done = false;
> + init_waitqueue_head(&req->acked);
> + spin_lock_irqsave(&vpmem->pmem_lock, flags);
> +
> + sg_init_one(&sg, req, sizeof(req));
What are you trying to do here?
sizeof(req) == sizeof(struct virtio_pmem_request *) == sizeof(void *)
Did you mean sizeof(*req)?
But why map struct virtio_pmem_request to the device? struct
virtio_pmem_request is the driver-internal request state and is not part
of the hardware interface.
> + sgs[0] = &sg;
> + sg_init_one(&ret, &req->ret, sizeof(req->ret));
> + sgs[1] = &ret;
> + err = virtqueue_add_sgs(vpmem->req_vq, sgs, 1, 1, req, GFP_ATOMIC);
> + if (err) {
> + dev_err(&vdev->dev, "failed to send command to virtio pmem device\n");
This can happen if the virtqueue is full. Printing a message and
failing the flush isn't appropriate. This thread needs to wait until
virtqueue space becomes available.
> + spin_unlock_irqrestore(&vpmem->pmem_lock, flags);
> + return -ENOSPC;
req is leaked.
> + virtio_device_ready(vdev);
This call isn't needed. Driver use it when they wish to submit buffers
on virtqueues before ->probe() returns.
> diff --git a/include/linux/virtio_pmem.h b/include/linux/virtio_pmem.h
> new file mode 100644
> index 0000000..0f83d9c
> --- /dev/null
> +++ b/include/linux/virtio_pmem.h
include/ is for declarations (e.g. kernel APIs) needed by other
compilation units. The contents of this header are internal to the
virtio_pmem driver implementation and can therefore be in virtio_pmem.c.
include/linux/virtio_pmem.h isn't necessary since nothing besides
virtio_pmem.c will need to include it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2018-07-17 13:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 7:52 [RFC v3 0/2] kvm "fake DAX" device flushing Pankaj Gupta
2018-07-13 7:52 ` [RFC v3 1/2] libnvdimm: Add flush callback for virtio pmem Pankaj Gupta
2018-07-13 20:35 ` Luiz Capitulino
2018-07-16 8:13 ` Pankaj Gupta
2018-07-13 7:52 ` [RFC v3 2/2] virtio-pmem: Add virtio pmem driver Pankaj Gupta
2018-07-13 20:38 ` Luiz Capitulino
2018-07-16 11:46 ` [Qemu-devel] " Pankaj Gupta
2018-07-16 14:03 ` Luiz Capitulino
2018-07-16 15:11 ` Pankaj Gupta
2018-07-17 13:11 ` Stefan Hajnoczi [this message]
2018-07-18 7:05 ` Pankaj Gupta
2018-07-13 7:52 ` [RFC v3] qemu: Add virtio pmem device Pankaj Gupta
2018-07-18 12:55 ` Luiz Capitulino
2018-07-19 5:48 ` [Qemu-devel] " Pankaj Gupta
2018-07-19 12:16 ` Stefan Hajnoczi
2018-07-19 12:48 ` Luiz Capitulino
2018-07-19 12:57 ` Luiz Capitulino
2018-07-20 13:04 ` Pankaj Gupta
2018-07-19 13:58 ` David Hildenbrand
2018-07-19 15:48 ` Luiz Capitulino
2018-07-20 13:02 ` Pankaj Gupta
2018-07-19 12:39 ` Luiz Capitulino
2018-07-24 16:13 ` Eric Blake
2018-07-25 5:01 ` [Qemu-devel] " Pankaj Gupta
2018-07-25 12:19 ` Eric Blake
2018-07-25 12:47 ` Pankaj Gupta
2018-08-28 12:13 ` [RFC v3 0/2] kvm "fake DAX" device flushing David Hildenbrand
2018-08-28 12:39 ` [Qemu-devel] " Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717131156.GA13498@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=hch@infradead.org \
--cc=imammedo@redhat.com \
--cc=jack@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=niteshnarayanlal@hotmail.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riel@surriel.com \
--cc=ross.zwisler@intel.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).