From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2437FECDFB8 for ; Tue, 17 Jul 2018 21:46:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C36EC206B7 for ; Tue, 17 Jul 2018 21:46:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="s6XkD5u6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C36EC206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730735AbeGQWUp (ORCPT ); Tue, 17 Jul 2018 18:20:45 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:50502 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729713AbeGQWUp (ORCPT ); Tue, 17 Jul 2018 18:20:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0ohJIOhrzmWjWIsJX31VurnBqjwo6diRJ1ZrQ1KI/e0=; b=s6XkD5u6bc22WE4rSG4qBkIJa NQGkzB+viGogHXdAs/Lrbt+45CBFplIYh2cdOpZLRtrPN6aFcCV6DF7wbWdPOsaI+qdVhT2sfNoAj 0Ikp2+kRbLMf0QtG/mpxby3wWHOpJQy/Q3x82r3t6Xod8D674PKYIk8cil2DzFx8UcsCHBP/wfTvR Tymsh8gX1ptS1oMKv8Tu58fJiyw7DqC6cQAMcASmcQesfc8OAUGEeQGil+F7L+dhXMDmX2VNaww4g jEGBCufoZKFJN45NjZKyZQyYNk7ousuJChsB9kjQreeMwkgeiMju4b76ILErsTgepUN8Ug3jz7Kcl JqVADdpxg==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1ffXnH-0001wY-OV; Tue, 17 Jul 2018 21:46:03 +0000 Date: Tue, 17 Jul 2018 14:46:03 -0700 From: Matthew Wilcox To: Bjorn Helgaas Cc: Martin Mares , Logan Gunthorpe , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, Stephen Bates , Christoph Hellwig , Bjorn Helgaas , Jonathan Corbet , Ingo Molnar , Thomas Gleixner , "Paul E. McKenney" , Marc Zyngier , Kai-Heng Feng , Frederic Weisbecker , Dan Williams , =?iso-8859-1?B?Suly9G1l?= Glisse , Benjamin Herrenschmidt , Alex Williamson , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: lspci: Display path to device Message-ID: <20180717214603.GB1771@bombadil.infradead.org> References: <20180717170204.30470-1-logang@deltatee.com> <20180717203900.GA1771@bombadil.infradead.org> <20180717210053.GB128988@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180717210053.GB128988@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 17, 2018 at 04:00:53PM -0500, Bjorn Helgaas wrote: > On Tue, Jul 17, 2018 at 01:39:00PM -0700, Matthew Wilcox wrote: > > The Nehalem system makes an interesting testcase because it exposes some > > registers in fake PCIe devices that aren't behind the root ports. eg: > > > > ff:06.3 Host bridge: Intel Corporation Xeon 5500/Core i7 Integrated Memory Controller Channel 2 Thermal Control Registers (rev 04) > > I think these appear as conventional PCI devices; at least the ones > I've seen, e.g., [1], don't have a PCIe capability, so I think it > makes sense that they're not behind a root port. > > [1] https://bugzilla5.redhat.com/attachment.cgi?id=433169 Oh, I don't think we're doing anything wrong with how we're displaying them or what we're doing with what the system presents to us. My only point was that this is a good test-case for code which assumes that all PCI devices lie under a PCIe root port. At one point during development, my code reported that device up there as /06.3 Host bridge: Intel Corporation Xeon 5500/Core i7 Integrated Memory Controller Channel 2 Thermal Control Registers (rev 04) but since I had that system available to test with, I spotted that problem and made it present that device as ff:06.3 (both with and without -P).