linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: usb: rtl8150: demote allmulti message to dev_dbg()
@ 2018-07-16 22:58 David Lechner
  2018-07-18  6:10 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: David Lechner @ 2018-07-16 22:58 UTC (permalink / raw)
  To: Petko Manolov
  Cc: David Lechner, David S. Miller, linux-usb, netdev, linux-kernel

This driver can spam the kernel log with multiple messages of:

    net eth0: eth0: allmulti set

Usually 4 or 8 at a time (probably because of using ConnMan).

This message doesn't seem useful, so let's demote it from dev_info()
to dev_dbg().

Signed-off-by: David Lechner <david@lechnology.com>
---
 drivers/net/usb/rtl8150.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
index 0e81d4c441d9..80373a9171dd 100644
--- a/drivers/net/usb/rtl8150.c
+++ b/drivers/net/usb/rtl8150.c
@@ -682,7 +682,7 @@ static void rtl8150_set_multicast(struct net_device *netdev)
 		   (netdev->flags & IFF_ALLMULTI)) {
 		rx_creg &= 0xfffe;
 		rx_creg |= 0x0002;
-		dev_info(&netdev->dev, "%s: allmulti set\n", netdev->name);
+		dev_dbg(&netdev->dev, "%s: allmulti set\n", netdev->name);
 	} else {
 		/* ~RX_MULTICAST, ~RX_PROMISCUOUS */
 		rx_creg &= 0x00fc;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: usb: rtl8150: demote allmulti message to dev_dbg()
  2018-07-16 22:58 [PATCH] net: usb: rtl8150: demote allmulti message to dev_dbg() David Lechner
@ 2018-07-18  6:10 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-07-18  6:10 UTC (permalink / raw)
  To: david; +Cc: petkan, linux-usb, netdev, linux-kernel

From: David Lechner <david@lechnology.com>
Date: Mon, 16 Jul 2018 17:58:10 -0500

> This driver can spam the kernel log with multiple messages of:
> 
>     net eth0: eth0: allmulti set
> 
> Usually 4 or 8 at a time (probably because of using ConnMan).
> 
> This message doesn't seem useful, so let's demote it from dev_info()
> to dev_dbg().
> 
> Signed-off-by: David Lechner <david@lechnology.com>

Applied, thanks David.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-18  6:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-16 22:58 [PATCH] net: usb: rtl8150: demote allmulti message to dev_dbg() David Lechner
2018-07-18  6:10 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).