From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A08FAECDFB8 for ; Wed, 18 Jul 2018 08:24:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65F4320693 for ; Wed, 18 Jul 2018 08:24:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65F4320693 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730267AbeGRJBc (ORCPT ); Wed, 18 Jul 2018 05:01:32 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34788 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbeGRJBc (ORCPT ); Wed, 18 Jul 2018 05:01:32 -0400 Received: from localhost (LFbn-1-12238-233.w90-92.abo.wanadoo.fr [90.92.53.233]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id A1D7986A; Wed, 18 Jul 2018 08:24:46 +0000 (UTC) Date: Wed, 18 Jul 2018 10:24:44 +0200 From: Greg Kroah-Hartman To: Konstantin Khlebnikov Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Randy Dunlap , Rasmus Villemoes , Paul Menzel , Masahiro Yamada Subject: Re: [PATCH 4.4 14/43] tools build: fix # escaping in .cmd files for future Make Message-ID: <20180718082444.GA1359@kroah.com> References: <20180716073511.796555857@linuxfoundation.org> <20180716073513.350026232@linuxfoundation.org> <20180717131542.GC5171@kroah.com> <6b871e03-f1fa-3546-8125-3639891eb828@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b871e03-f1fa-3546-8125-3639891eb828@yandex-team.ru> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 17, 2018 at 10:51:29PM +0300, Konstantin Khlebnikov wrote: > On 17.07.2018 16:15, Greg Kroah-Hartman wrote: > > On Tue, Jul 17, 2018 at 03:57:21PM +0300, Konstantin Khlebnikov wrote: > > > This commit depends on commit 9564a8cf422d7b58f6e857e3546d346fa970191e > > > "Kbuild: fix # escaping in .cmd files for future Make" > > > which is missing in 4.4.141 > > > > > > > > > this breaks compilation of tools/perf for me > > > > > > make -C tools/perf V=1 JOBS=24 WERROR=0 NO_GTK2=1 LDFLAGS=-static all > > > make[1]: Entering directory `/tmp/buildd/linux-yandex-4.4.141/tools/perf' > > > BUILD: Doing 'make -j24' parallel build > > > > > > Auto-detecting system features: > > > ... dwarf: [ on ] > > > ... dwarf_getlocations: [ OFF ] > > > ... glibc: [ on ] > > > ... gtk2: [ OFF ] > > > ... libaudit: [ on ] > > > ... libbfd: [ on ] > > > ... libelf: [ on ] > > > ... libnuma: [ on ] > > > ... numa_num_possible_cpus: [ on ] > > > ... libperl: [ OFF ] > > > ... libpython: [ OFF ] > > > ... libslang: [ on ] > > > ... libunwind: [ on ] > > > ... libdw-dwarf-unwind: [ OFF ] > > > ... zlib: [ on ] > > > ... lzma: [ on ] > > > ... get_cpuid: [ on ] > > > ... bpf: [ on ] > > > > > > config/Makefile:274: No libdw DWARF unwind found, Please install elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR > > > config/Makefile:282: Old libdw.h, finding variables at given 'perf probe' point will not work, install elfutils-devel/libdw-dev >= 0.157 > > > config/Makefile:458: Missing perl devel files. Disabling perl scripting support, please install perl-ExtUtils-Embed/libperl-dev > > > config/Makefile:501: No 'Python.h' (for Python 2.x support) was found: disables Python support - please install python-devel/python-dev > > > $(:) > > > make -C /tmp/buildd/linux-yandex-4.4.141/tools/build fixdep > > > /bin/sh util/PERF-VERSION-GEN > > > make -f /tmp/buildd/linux-yandex-4.4.141/tools/build/Makefile.build dir=. obj=fixdep > > > . util/generate-cmdlist.sh > common-cmds.h+ && mv common-cmds.h+ common-cmds.h > > > .fixdep.o.cmd:1: *** missing separator. Stop. > > > make[3]: *** [fixdep-in.o] Error 2 > > > make[2]: *** [fixdep] Error 2 > > > > Ok, backporting the Makefile fixes resolves this issue. But perf still > > fails to build for me due to some futex errors, which is odd, do you see > > that too? > > Compilation fails only for modern glibc, like in ubuntu 18.04 bionic. > Xenial 16.04 and precise 12.04 are fine. > > I've bisected to indirect fix in linux 4.8 > commit cec07f53c398f22576df77052c4777dc13f14962 > ("perf tools: Move syscall number fallbacks from perf-sys.h to tools/arch/x86/include/asm/") > > To 4.4.y it applies clearly. Yes! Thanks for figuring this out, it's been bothering me for a while now. Now queued up. greg k-h