From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Marcel Ziswiler <marcel@ziswiler.com>
Cc: linux-mtd@lists.infradead.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, Stefan Agner <stefan@agner.ch>,
boris.brezillon@bootlin.com, dev@lynxeye.de,
mirza.krak@gmail.com, benjamin.lindqvist@endian.se,
krzk@kernel.org, marek.vasut@gmail.com, richard@nod.at,
digetx@gmail.com, computersforpeace@gmail.com,
dwmw2@infradead.org, dan.carpenter@oracle.com,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH v2] mtd: rawnand: tegra: check bounds of die_nr properly
Date: Wed, 18 Jul 2018 09:45:44 +0200 [thread overview]
Message-ID: <20180718094544.76607c0f@xps13> (raw)
In-Reply-To: <20180717084618.25249-1-marcel@ziswiler.com>
Hi Marcel,
Marcel Ziswiler <marcel@ziswiler.com> wrote on Tue, 17 Jul 2018
10:46:18 +0200:
> From: Stefan Agner <stefan@agner.ch>
>
> The Tegra driver currently only support a single chip select, hence
> check boundaries accordingly. This fixes a off by one issue catched
> with Smatch:
> drivers/mtd/nand/raw/tegra_nand.c:476 tegra_nand_select_chip()
> warn: array off by one? 'nand->cs[die_nr]'
>
> Also warn in case the stack asks for a chip select we currently do
> not support.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Applied on nand/next in place of the previous one (with my SoB after
yours).
Thanks,
Miquèl
prev parent reply other threads:[~2018-07-18 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 8:46 [PATCH v2] mtd: rawnand: tegra: check bounds of die_nr properly Marcel Ziswiler
2018-07-18 7:45 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718094544.76607c0f@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=benjamin.lindqvist@endian.se \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=dev@lynxeye.de \
--cc=digetx@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=marek.vasut@gmail.com \
--cc=mirza.krak@gmail.com \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).