From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4189ECDFB8 for ; Wed, 18 Jul 2018 10:51:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAABE2075C for ; Wed, 18 Jul 2018 10:51:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="XrOPruhy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAABE2075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729306AbeGRL2g (ORCPT ); Wed, 18 Jul 2018 07:28:36 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:54628 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726968AbeGRL2g (ORCPT ); Wed, 18 Jul 2018 07:28:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wiZs7vtTpmFEdg5hRz+A7mtBW33+kxmnwW72OLDvzEU=; b=XrOPruhy210Ri6pYYq3KCQ6k0 Fp85F6sDbpmkM8T4J1sOkUc9NhxxLa2sxPMb8M4N0mEra3qx5ce1a5KXwIKqA3mIWEAoaPwYiLhKx MzZ95KLyzNwxUrcpNAm3nuMSWoDtDtpmun5VzvKVPbvtQ8ltK5byKmlUKRSHJjsNFW/x8=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ffk36-0003S4-Js; Wed, 18 Jul 2018 10:51:12 +0000 Received: from broonie by debutante with local (Exim 4.91) (envelope-from ) id 1ffk36-0003G1-5m; Wed, 18 Jul 2018 11:51:12 +0100 Date: Wed, 18 Jul 2018 11:51:12 +0100 From: Mark Brown To: Alexandre Belloni Cc: James Hogan , Paul Burton , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Thomas Petazzoni , Allan Nielsen Subject: Re: [PATCH 1/5] spi: dw: fix possible race condition Message-ID: <20180718105112.GF5700@sirena.org.uk> References: <20180717142314.32337-1-alexandre.belloni@bootlin.com> <20180717142314.32337-2-alexandre.belloni@bootlin.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VuQYccsttdhdIfIP" Content-Disposition: inline In-Reply-To: <20180717142314.32337-2-alexandre.belloni@bootlin.com> X-Cookie: Remember the... the... uhh..... User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --VuQYccsttdhdIfIP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 17, 2018 at 04:23:10PM +0200, Alexandre Belloni wrote: > It is possible to get an interrupt as soon as it is requested. dw_spi_irq > does spi_controller_get_devdata(master) and expects it to be different th= an > NULL. However, spi_controller_set_devdata() is called after request_irq(), > resulting in the following crash: >=20 > CPU 0 Unable to handle kernel paging request at virtual address 00000030,= epc =3D=3D 8058e09c, ra =3D=3D 8018ff90 > [...] > Call Trace: > [<8058e09c>] dw_spi_irq+0x8/0x64 > [<8018ff90>] __handle_irq_event_percpu+0x70/0x1d4 > [<80190128>] handle_irq_event_percpu+0x34/0x8c > [<801901c4>] handle_irq_event+0x44/0x80 > [<801951a8>] handle_level_irq+0xdc/0x194 > [<8018f580>] generic_handle_irq+0x38/0x50 > [<804c6924>] ocelot_irq_handler+0x104/0x1c0 > [<8018f580>] generic_handle_irq+0x38/0x50 Please think hard before including complete backtraces in upstream reports, they are very large and contain almost no useful information relative to their size so often obscure the relevant content in your message. If part of the backtrace is usefully illustrative then it's usually better to pull out the relevant sections. --VuQYccsttdhdIfIP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAltPG58ACgkQJNaLcl1U h9BvoAf/f/6rtJgyme3vvCowQ16IZAJN774h4L9HXBSudyiaol+mrAx4ZlJdHxzB OYZwbbqeHHLqr9E9wdQCHDfNz0gAwXzg/kt5BbuNBx5oHLj7JESirezasI5GidMK nnW92RtEwrt5ygajIO33E/cWeNwLBo3Au0H2/hJnMA4L6RakTJoRT0h6+80XUkJR q5cHWMH8+kcvPk344EvZ/VkN3bNGo3I1jvcFSYYRwmHe42JWiQSYURBbDynJnI3t Bx/vo5KR+aA5n3uYfbwMD/Gj9ZbjU3pt/4P4Xhp0u4TkMKZSu3sEuO5EuIbQZ0Fn Fcu9kqKRVRq5DMt91jBRMEjjEP7HzQ== =nPpa -----END PGP SIGNATURE----- --VuQYccsttdhdIfIP--