From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator
Date: Wed, 18 Jul 2018 16:09:39 +0200 [thread overview]
Message-ID: <20180718160939.5650559b@bootlin.com> (raw)
In-Reply-To: <20180718130846.GA5380@embeddedor.com>
Hi Gustavo,
On Wed, 18 Jul 2018 08:08:46 -0500
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
>The use of the | operator always leads to true, which looks rather
>suspect in this case.
>
>Fix this by using & instead.
>
Acked-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Good catch, thanks.
Maxime
next prev parent reply other threads:[~2018-07-18 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 13:08 [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator Gustavo A. R. Silva
2018-07-18 14:09 ` Maxime Chevallier [this message]
2018-07-18 14:32 ` Gustavo A. R. Silva
2018-07-18 17:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718160939.5650559b@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).