From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC72ECDFBB for ; Wed, 18 Jul 2018 21:43:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BAB42075A for ; Wed, 18 Jul 2018 21:43:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BAB42075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730651AbeGRWWs convert rfc822-to-8bit (ORCPT ); Wed, 18 Jul 2018 18:22:48 -0400 Received: from mail.bootlin.com ([62.4.15.54]:41776 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730255AbeGRWWs (ORCPT ); Wed, 18 Jul 2018 18:22:48 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id F192020731; Wed, 18 Jul 2018 23:42:56 +0200 (CEST) Received: from xps13 (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id 5C8DC206ED; Wed, 18 Jul 2018 23:42:56 +0200 (CEST) Date: Wed, 18 Jul 2018 23:42:55 +0200 From: Miquel Raynal To: Boris Brezillon Cc: Abhishek Sahu , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Andy Gross Subject: Re: [PATCH 4/5] mtd: rawnand: qcom: update BBT related flags Message-ID: <20180718234255.4e51c188@xps13> In-Reply-To: <20180718234144.158217f2@xps13> References: <1530863519-5564-1-git-send-email-absahu@codeaurora.org> <1530863519-5564-5-git-send-email-absahu@codeaurora.org> <20180718231526.38046099@xps13> <20180718233637.49a39751@bbrezillon> <20180718234144.158217f2@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Abhishek, Miquel Raynal wrote on Wed, 18 Jul 2018 23:41:44 +0200: > Hi Boris, > > Boris Brezillon wrote on Wed, 18 Jul 2018 > 23:36:37 +0200: > > > On Wed, 18 Jul 2018 23:15:26 +0200 > > Miquel Raynal wrote: > > > > > Hi Abhishek, > > > > > > Abhishek Sahu wrote on Fri, 6 Jul 2018 > > > 13:21:58 +0530: > > > > > > > Remove the NAND_SKIP_BBTSCAN to use RAM based BBT. > > > > > > Unless I am understanding it the wrong way, NAND_SKIP_BBTSCAN will skip > > > the scan of the on-chip BBT and will scan every block to construct a > > > RAM, based BBT thanks to the BBM. > > > > > > So flash based BBT is already unused and removing this flag is a > > > mistake, right? > > > > ->scan_bbt() is also taking care of building the in-RAM BBT based on > > BBM when no on-flash BBT is provided, so I think it's the right thing > > to do. > > Oh right. Then doing so is harmless. Could you please update the commit log to reflect this aspect? > > Thanks for the clarification. > Miquèl