linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srikanth Korangala Hari <srikanth.h@samsung.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"keescook@chromium.org" <keescook@chromium.org>,
	"ben.hutchings@codethink.co.uk" <ben.hutchings@codethink.co.uk>,
	"perex@perex.cz" <perex@perex.cz>,
	"elfring@users.sourceforge.net" <elfring@users.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	CPGS <cpgs@samsung.com>
Subject: RE: Re: [PATCHv2 1/1] Preventive fix in sound module
Date: Thu, 19 Jul 2018 10:46:31 +0530	[thread overview]
Message-ID: <20180719051631epcms5p8224b903510a4fe2414c30f3b6b02d7de@epcms5p8> (raw)
In-Reply-To: <s5hd0vkbm7r.wl-tiwai@suse.de>

 
> The checks in proc are moot if we guarantee the non-NULL card at
> snd_timer_new() in the above.
 
> So it's not about fixing in sound module.  It serves right.  Your
> patch would add a sanity check to catch a buggy code in the caller
> side.
 
You are right Takashi, as you said this changes will catch buggy code in caller side.

Thank you for your respose.

Thanks,
Srikanth
 
 

      parent reply	other threads:[~2018-07-19  5:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180718100741epcas1p393bea852d102e903ab6a48ff952761db@epcas1p3.samsung.com>
2018-07-18 10:07 ` [PATCH 1/1] Preventive fix in sound module Srikanth K H
2018-07-18 10:16   ` Takashi Iwai
     [not found]   ` <CGME20180718100741epcas1p393bea852d102e903ab6a48ff952761db@epcms5p1>
2018-07-18 10:58     ` Srikanth Korangala Hari
2018-07-18 12:14       ` Takashi Iwai
     [not found]   ` <CGME20180718150653epcas2p3c2f0e36569529df72ce0b79a22867eac@epcas2p3.samsung.com>
2018-07-18 15:07     ` [PATCHv2 " Srikanth K H
2018-07-18 15:24       ` Takashi Iwai
     [not found]       ` <CGME20180718150653epcas2p3c2f0e36569529df72ce0b79a22867eac@epcms5p8>
2018-07-19  5:16         ` Srikanth Korangala Hari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719051631epcms5p8224b903510a4fe2414c30f3b6b02d7de@epcms5p8 \
    --to=srikanth.h@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=ben.hutchings@codethink.co.uk \
    --cc=cpgs@samsung.com \
    --cc=elfring@users.sourceforge.net \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).