From: Oscar Salvador <osalvador@techadventures.net>
To: Pavel Tatashin <pasha.tatashin@oracle.com>
Cc: akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz,
iamjoonsoo.kim@lge.com, aaron.lu@intel.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH 1/3] mm/page_alloc: Move ifdefery out of free_area_init_core
Date: Thu, 19 Jul 2018 14:19:02 +0200 [thread overview]
Message-ID: <20180719121902.GB8750@techadventures.net> (raw)
In-Reply-To: <20180718141150.imiyuust5txfmfvw@xakep.localdomain>
On Wed, Jul 18, 2018 at 10:11:50AM -0400, Pavel Tatashin wrote:
> On 18-07-18 14:47:20, osalvador@techadventures.net wrote:
> > From: Oscar Salvador <osalvador@suse.de>
> >
> > Moving the #ifdefs out of the function makes it easier to follow.
> >
> > Signed-off-by: Oscar Salvador <osalvador@suse.de>
>
> Hi Oscar,
>
> Reviewed-by: Pavel Tatashin <pasha.tatashin@oracle.com>
>
> Please include the following patch in your series, to get rid of the last
> ifdef in this function.
Hi Pavel,
I am about to send v2 with this patch included, but I just wanted to let you know
this:
> + zone_set_nid(nid);
This should be:
zone_set_nid(zone, nid);
I fixed it up in your patch, I hope that is ok.
Thanks
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2018-07-19 12:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 12:47 [PATCH 0/3] Re-structure free_area_init_node / free_area_init_core osalvador
2018-07-18 12:47 ` [PATCH 1/3] mm/page_alloc: Move ifdefery out of free_area_init_core osalvador
2018-07-18 13:37 ` Michal Hocko
2018-07-18 14:11 ` Pavel Tatashin
2018-07-18 15:15 ` Oscar Salvador
2018-07-19 12:19 ` Oscar Salvador [this message]
2018-07-19 13:18 ` Pavel Tatashin
2018-07-18 12:47 ` [PATCH 2/3] mm/page_alloc: Refactor free_area_init_core osalvador
2018-07-18 13:36 ` Michal Hocko
2018-07-18 14:12 ` Oscar Salvador
2018-07-18 15:11 ` Oscar Salvador
2018-07-18 12:47 ` [PATCH 3/3] mm/page_alloc: Split context in free_area_init_node osalvador
2018-07-18 14:34 ` Pavel Tatashin
2018-07-19 7:35 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719121902.GB8750@techadventures.net \
--to=osalvador@techadventures.net \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).