From: Michal Hocko <mhocko@kernel.org>
To: Pavel Tatashin <pasha.tatashin@oracle.com>
Cc: osalvador@techadventures.net, akpm@linux-foundation.org,
vbabka@suse.cz, aaron.lu@intel.com, iamjoonsoo.kim@lge.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH v2 2/5] mm: access zone->node via zone_to_nid() and zone_set_nid()
Date: Thu, 19 Jul 2018 15:47:16 +0200 [thread overview]
Message-ID: <20180719134716.GF7193@dhcp22.suse.cz> (raw)
In-Reply-To: <760195c6-7cfb-76db-1c5c-b85456f3a4ad@oracle.com>
On Thu 19-07-18 09:44:09, Pavel Tatashin wrote:
>
>
> On 07/19/2018 09:40 AM, Michal Hocko wrote:
> > On Thu 19-07-18 15:27:37, osalvador@techadventures.net wrote:
> >> From: Pavel Tatashin <pasha.tatashin@oracle.com>
> >>
> >> zone->node is configured only when CONFIG_NUMA=y, so it is a good idea to
> >> have inline functions to access this field in order to avoid ifdef's in
> >> c files.
> >
> > Is this a manual find & replace or did you use some scripts?
>
> I used opengrok:
>
> http://src.illumos.org/source/search?q=%22zone-%3Enode%22&defs=&refs=&path=&hist=&project=linux-master
>
> http://src.illumos.org/source/search?q=%22z-%3Enode%22&defs=&refs=&path=&hist=&project=linux-master
Then it is good to mention that in the changelog so that people might
use the same tool locally and compare the result or even learn about the
tool ;)
> > The change makes sense, but I haven't checked that all the places are
> > replaced properly. If not we can replace them later.
> >
> >> Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
> >> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> >> Reviewed-by: Oscar Salvador <osalvador@suse.de>
> >
> > Acked-by: Michal Hocko <mhocko@suse.com>
>
> Thank you,
> Pavel
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-07-19 13:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 13:27 [PATCH v2 0/5] Refactor free_area_init_node/free_area_init_core osalvador
2018-07-19 13:27 ` [PATCH v2 1/5] mm/page_alloc: Move ifdefery out of free_area_init_core osalvador
2018-07-19 13:27 ` [PATCH v2 2/5] mm: access zone->node via zone_to_nid() and zone_set_nid() osalvador
2018-07-19 13:40 ` Michal Hocko
2018-07-19 13:44 ` Pavel Tatashin
2018-07-19 13:47 ` Michal Hocko [this message]
2018-07-19 13:27 ` [PATCH v2 3/5] mm/page_alloc: Optimize free_area_init_core osalvador
2018-07-19 13:44 ` Michal Hocko
2018-07-19 14:03 ` Oscar Salvador
2018-07-19 15:15 ` Michal Hocko
2018-07-19 20:52 ` Oscar Salvador
2018-07-20 10:03 ` Oscar Salvador
2018-07-23 8:35 ` Michal Hocko
2018-07-23 11:42 ` Oscar Salvador
2018-07-23 8:30 ` Michal Hocko
2018-07-19 13:27 ` [PATCH v2 4/5] mm/page_alloc: Inline function to handle CONFIG_DEFERRED_STRUCT_PAGE_INIT osalvador
2018-07-19 13:45 ` Michal Hocko
2018-07-19 13:27 ` [PATCH v2 5/5] mm/page_alloc: Only call pgdat_set_deferred_range when the system boots osalvador
2018-07-19 13:46 ` Michal Hocko
2018-07-19 13:58 ` Oscar Salvador
2018-07-19 14:03 ` Michal Hocko
2018-07-19 14:27 ` Pavel Tatashin
2018-07-19 15:01 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719134716.GF7193@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=osalvador@techadventures.net \
--cc=pasha.tatashin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).