linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinod <vkoul@kernel.org>
To: hannah@marvell.com
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
	thomas.petazzoni@bootlin.com, linux-kernel@vger.kernel.org,
	nadavh@marvell.com, omrii@marvell.com, oferh@marvell.com,
	gregory.clement@bootlin.com
Subject: Re: [PATCH 3/5] dmaengine: mv_xor_v2: convert callback to helper function
Date: Fri, 20 Jul 2018 14:59:21 +0530	[thread overview]
Message-ID: <20180720092921.GR3219@vkoul-mobl> (raw)
In-Reply-To: <1531823403-3683-4-git-send-email-hannah@marvell.com>

On 17-07-18, 13:30, hannah@marvell.com wrote:
> From: Hanna Hawa <hannah@marvell.com>
> 
> This is in preperation of moving to a callback that provides results to the

typo preperation

> callback for the transaction. The conversion will maintain current behavior
> and the driver must convert to new callback mechanism at a later time in
> order to receive results.
> 
> Signed-off-by: Hanna Hawa <hannah@marvell.com>
> ---
>  drivers/dma/mv_xor_v2.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
> index e718498..14e2a7a 100644
> --- a/drivers/dma/mv_xor_v2.c
> +++ b/drivers/dma/mv_xor_v2.c
> @@ -589,9 +589,8 @@ static void mv_xor_v2_tasklet(unsigned long data)
>  			 */
>  			dma_cookie_complete(&next_pending_sw_desc->async_tx);
>  
> -			if (next_pending_sw_desc->async_tx.callback)
> -				next_pending_sw_desc->async_tx.callback(
> -				next_pending_sw_desc->async_tx.callback_param);
> +			dmaengine_desc_get_callback_invoke(
> +					&next_pending_sw_desc->async_tx, NULL);
>  
>  			dma_descriptor_unmap(&next_pending_sw_desc->async_tx);
>  		}

-- 
~Vinod

  reply	other threads:[~2018-07-20  9:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 10:29 [PATCH 0/5] dmaengine: mv_xor_v2: fixes and alignment for XOR-v2 driver hannah
2018-07-17 10:29 ` [PATCH 1/5] dmaengine: mv_xor_v2: explicitly freeup irq hannah
2018-07-17 10:30 ` [PATCH 2/5] dmaengine: mv_xor_v2: kill the tasklets upon exit hannah
2018-07-17 10:30 ` [PATCH 3/5] dmaengine: mv_xor_v2: convert callback to helper function hannah
2018-07-20  9:29   ` Vinod [this message]
2018-07-17 10:30 ` [PATCH 4/5] dmaengine: mv_xor_v2: move unmap to before callback hannah
2018-07-17 10:30 ` [PATCH 5/5] dmaengine: mv_xor_v2: enable COMPILE_TEST hannah
2018-07-20  9:32 ` [PATCH 0/5] dmaengine: mv_xor_v2: fixes and alignment for XOR-v2 driver Vinod

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180720092921.GR3219@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=hannah@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nadavh@marvell.com \
    --cc=oferh@marvell.com \
    --cc=omrii@marvell.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).