From: Juri Lelli <juri.lelli@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Daniel Bristot de Oliveira <bristot@redhat.com>,
linux-kernel@vger.kernel.org,
Clark Williams <williams@redhat.com>,
Luca Abeni <luca.abeni@santannapisa.it>,
Tommaso Cucinotta <tommaso.cucinotta@santannapisa.it>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task
Date: Fri, 20 Jul 2018 14:53:29 +0200 [thread overview]
Message-ID: <20180720125329.GD3642@localhost.localdomain> (raw)
In-Reply-To: <20180720124821.GB2512@hirez.programming.kicks-ass.net>
On 20/07/18 14:48, Peter Zijlstra wrote:
> On Fri, Jul 20, 2018 at 02:46:15PM +0200, Peter Zijlstra wrote:
> > On Fri, Jul 20, 2018 at 11:16:30AM +0200, Daniel Bristot de Oliveira wrote:
> > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> > > index fbfc3f1d368a..8b50eea4b607 100644
> > > --- a/kernel/sched/deadline.c
> > > +++ b/kernel/sched/deadline.c
> > > @@ -2090,8 +2090,14 @@ static int push_dl_task(struct rq *rq)
> > > sub_rq_bw(&next_task->dl, &rq->dl);
> > > set_task_cpu(next_task, later_rq->cpu);
> > > add_rq_bw(&next_task->dl, &later_rq->dl);
> > > +
> > > + /*
> > > + * Update the later_rq clock here, because the clock is used
> > > + * by the cpufreq_update_util() inside __add_running_bw().
> > > + */
> > > + update_rq_clock(later_rq);
> > > add_running_bw(&next_task->dl, &later_rq->dl);
> > > - activate_task(later_rq, next_task, 0);
> > > + activate_task(later_rq, next_task, ENQUEUE_NOCLOCK);
> > > ret = 1;
> > >
> > > resched_curr(later_rq);
> >
> > Why isn't push_rt_task() affected by the very same issue?
>
> Aah, I see, its the add_running_bw() think; for which RT doesn't have a
> counter-part.
Right, but doesn't enqueue_top_rt_rq end-up being called by activate_
task on lowest_rq? Mmm.
next prev parent reply other threads:[~2018-07-20 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 9:16 [PATCH V3] sched/deadline: Update rq_clock of later_rq when pushing a task Daniel Bristot de Oliveira
2018-07-20 12:46 ` Peter Zijlstra
2018-07-20 12:48 ` Peter Zijlstra
2018-07-20 12:53 ` Juri Lelli [this message]
2018-07-20 15:36 ` Daniel Bristot de Oliveira
2018-07-20 15:45 ` Juri Lelli
2018-07-20 15:46 ` Peter Zijlstra
2018-07-25 14:21 ` [tip:sched/core] " tip-bot for Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720125329.GD3642@localhost.localdomain \
--to=juri.lelli@redhat.com \
--cc=bristot@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).