From: Segher Boessenkool <segher@kernel.crashing.org>
To: Joe Perches <joe@perches.com>
Cc: Dirk Gouders <dirk@gouders.net>,
Andy Whitcroft <apw@canonical.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] checkpatch: kbuild: if_changed: check for multiple calls in targets
Date: Fri, 20 Jul 2018 10:44:49 -0500 [thread overview]
Message-ID: <20180720154449.GC16221@gate.crashing.org> (raw)
In-Reply-To: <4977e9adba5e826d5e7e9f503e3ce8fbaa872af5.camel@perches.com>
On Fri, Jul 20, 2018 at 08:33:56AM -0700, Joe Perches wrote:
> On Fri, 2018-07-20 at 10:21 -0500, Segher Boessenkool wrote:
> > On Fri, Jul 20, 2018 at 03:06:37AM -0700, Joe Perches wrote:
> > > On Fri, 2018-07-20 at 09:48 +0200, Dirk Gouders wrote:
> > > > + # Check for multiple calls of if_changed within a target in Makefiles
> > > > + if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
> > >
> > > The uses of .* here are superfluous.
> >
> > And it looks like you wanted to match this only at the beginning of the
> > string, which would be /^Makefile/ etc.
>
> Nope.
>
> $realfile includes path and /^Makefile/ matches only the
> top level Makefile and none of the ones in subdirectories.
Then the .* is more mysterious :-)
(Maybe the script should use File::Basename).
Segher
prev parent reply other threads:[~2018-07-20 15:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 12:39 [PATCH] checkpatch: if_changed: check for multiple calls in targets Dirk Gouders
2018-07-16 15:23 ` Joe Perches
2018-07-17 9:32 ` Dirk Gouders
2018-07-20 7:48 ` [PATCH v2] checkpatch: kbuild: " Dirk Gouders
2018-07-20 10:06 ` Joe Perches
2018-07-20 15:21 ` Segher Boessenkool
2018-07-20 15:33 ` Joe Perches
2018-07-20 15:44 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720154449.GC16221@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=apw@canonical.com \
--cc=dirk@gouders.net \
--cc=joe@perches.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).