From: Jonathan Cameron <jic23@kernel.org>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Daniel Baluta <daniel.baluta@gmail.com>
Subject: Re: [PATCH v4] iio: chemical: Add support for Bosch BME680 sensor
Date: Sat, 21 Jul 2018 17:29:24 +0100 [thread overview]
Message-ID: <20180721172924.53619e6a@archlinux> (raw)
In-Reply-To: <20180721155230.GB11127@himanshu-Vostro-3559>
On Sat, 21 Jul 2018 21:22:30 +0530
Himanshu Jha <himanshujha199640@gmail.com> wrote:
> On Sat, Jul 21, 2018 at 06:43:51PM +0300, Andy Shevchenko wrote:
> > On Sat, Jul 21, 2018 at 6:36 PM, Himanshu Jha
> > <himanshujha199640@gmail.com> wrote:
> >
> > >> > + /* Look up table 1 for the possible gas range values */
> > >> > + u32 lookupTable1[16] = {2147483647u, 2147483647u, 2147483647u,
> > >> > + 2147483647u, 2147483647u, 2126008810u,
> > >> > + 2147483647u, 2130303777u, 2147483647u,
> > >> > + 2147483647u, 2143188679u, 2136746228u,
> > >> > + 2147483647u, 2126008810u, 2147483647u,
> > >> > + 2147483647u};
> >
> > This one needs perhaps a bit of though, but...
> >
> > >> > + /* Look up table 2 for the possible gas range values */
> > >> > + u32 lookupTable2[16] = {4096000000u, 2048000000u, 1024000000u,
> > >> > + 512000000u, 255744255u, 127110228u, 64000000u,
> > >> > + 32258064u, 16016016u, 8000000u, 4000000u,
> > >> > + 2000000u, 1000000u, 500000u, 250000u, 125000u};
> >
> > ...this one obviously just a not needed one. You may replace it with a
> > one constant and simple calculation to get either value (index from
> > value, or value from index).
>
> Not sure to understand your opinion!?
>
> Anything related to increase to .ro segment ?
>
> I think adding is better to let compiler optimise the code a bit
> further.
No, I missed this as didn't look too closely at those numbers.
They are almost by not quite simple power's of 2 * 125000.
Question is whether the very very small difference from that matter or not...
Andy is suggesting replacing this block of data with an equation that is
'near enough'.
>
> > --
> > With Best Regards,
> > Andy Shevchenko
>
next prev parent reply other threads:[~2018-07-21 16:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 21:31 [PATCH v4] iio: chemical: Add support for Bosch BME680 sensor Himanshu Jha
2018-07-21 15:19 ` Jonathan Cameron
2018-07-21 15:36 ` Himanshu Jha
2018-07-21 15:43 ` Andy Shevchenko
2018-07-21 15:52 ` Himanshu Jha
2018-07-21 16:29 ` Jonathan Cameron [this message]
2018-07-21 17:45 ` Daniel Baluta
2018-07-22 22:21 ` Himanshu Jha
2018-07-23 22:16 ` David Frey
2018-07-23 23:02 ` Himanshu Jha
2018-07-21 16:31 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180721172924.53619e6a@archlinux \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=himanshujha199640@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).