From: Peter Zijlstra <peterz@infradead.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
jbaron@akamai.com, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 0/2] fs/epoll: loosen irq safety when possible
Date: Sat, 21 Jul 2018 19:39:44 +0200 [thread overview]
Message-ID: <20180721173944.GV2494@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180721172120.kbdu4euc2wn4xzgf@linux-r8p5>
On Sat, Jul 21, 2018 at 10:21:20AM -0700, Davidlohr Bueso wrote:
> On Fri, 20 Jul 2018, Andrew Morton wrote:
>
> > We could open-code it locally. Add a couple of
> > WARN_ON_ONCE(irqs_disabled())? That might need re-benchmarking with
> > Xen but surely just reading the thing isn't too expensive?
>
> We could also pass on the responsibility to lockdep and just use
> lockdep_assert_irqs_disabled(). But I guess that would be less effective
> than to just open code it in epoll without lockdep -- note that over 80
> places in the kernel do this.
The lockdep thing is relatively recent. I think someone proposed to go
replace a bunch of the open-coded ones at some point.
next prev parent reply other threads:[~2018-07-21 17:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 17:29 [PATCH -next 0/2] fs/epoll: loosen irq safety when possible Davidlohr Bueso
2018-07-20 17:29 ` [PATCH 1/2] fs/epoll: loosen irq safety in ep_scan_ready_list() Davidlohr Bueso
2018-07-20 17:29 ` [PATCH 2/2] fs/epoll: loosen irq safety in epoll_insert() and epoll_remove() Davidlohr Bueso
2018-07-20 19:42 ` [PATCH -next 0/2] fs/epoll: loosen irq safety when possible Andrew Morton
2018-07-20 20:05 ` Davidlohr Bueso
2018-07-20 20:44 ` Andrew Morton
2018-07-21 0:22 ` Davidlohr Bueso
2018-07-21 17:21 ` Davidlohr Bueso
2018-07-21 17:39 ` Peter Zijlstra [this message]
2018-07-21 18:31 ` Davidlohr Bueso
2018-07-24 23:43 ` Andrew Morton
2018-09-06 19:11 ` Peter Zijlstra
2018-09-06 20:55 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180721173944.GV2494@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).