* [PATCH] genhd: register_disk: inform about dev_set_name() failure
@ 2018-07-21 22:28 Eugene Korenevsky
0 siblings, 0 replies; only message in thread
From: Eugene Korenevsky @ 2018-07-21 22:28 UTC (permalink / raw)
To: Jens Axboe, linux-kernel, linux-block
Although dev_set_name() failure is not fatal, it is better to print
a warning message into dmesg about it.
Signed-off-by: Eugene Korenevsky <ekorenevsky@gmail.com>
---
block/genhd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/genhd.c b/block/genhd.c
index f1543a45e73b..071f8cbd529a 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -577,7 +577,9 @@ static void register_disk(struct device *parent, struct gendisk *disk)
ddev->parent = parent;
- dev_set_name(ddev, "%s", disk->disk_name);
+ err = dev_set_name(ddev, "%s", disk->disk_name);
+ if (err)
+ pr_warn("%s: cannot set disk name: %d", __func__, err);
/* delay uevents, until we scanned partition table */
dev_set_uevent_suppress(ddev, 1);
--
2.18.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-07-21 22:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-21 22:28 [PATCH] genhd: register_disk: inform about dev_set_name() failure Eugene Korenevsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).