From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3965ECDFB8 for ; Sun, 22 Jul 2018 08:13:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F29B20875 for ; Sun, 22 Jul 2018 08:13:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NqV+VbOj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F29B20875 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728336AbeGVJJn (ORCPT ); Sun, 22 Jul 2018 05:09:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:46778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728001AbeGVJJn (ORCPT ); Sun, 22 Jul 2018 05:09:43 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 28F862086A; Sun, 22 Jul 2018 08:13:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1532247231; bh=lXeEtXz5HuhfkzMVvpqGYYTtwrMWmHbGWjeIjCFLWZ4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NqV+VbOjzjsdUo7VMlDA/s8ayna5bZuR8uRZKE9U12tZE/dZGWhCt3a+fm01aTWZT SDJ91ZSbnFea/7KEAuebUZIdSwXCOYoZ1YOew5zZD+JD2oeDfVZ6uCZvLF+tech9kp 6HILENei0pynNbPOOe+ZzObChV6sc20GtyzlbDvI= Date: Sun, 22 Jul 2018 09:13:47 +0100 From: Jonathan Cameron To: Dominique Martinet Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Lorenzo Bianconi , Linus Walleij , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/18] iio: change strncpy+truncation to strlcpy Message-ID: <20180722091347.1faa81f0@archlinux> In-Reply-To: <20180716114206.GA20555@nautica> References: <1531444483-17338-1-git-send-email-asmadeus@codewreck.org> <1531445134-19250-1-git-send-email-asmadeus@codewreck.org> <20180715113907.3813384d@archlinux> <20180716114206.GA20555@nautica> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Jul 2018 13:42:06 +0200 Dominique Martinet wrote: > Jonathan Cameron wrote on Sun, Jul 15, 2018: > > On Fri, 13 Jul 2018 03:25:34 +0200 > > Dominique Martinet wrote: =20 > > > Generated by scripts/coccinelle/misc/strncpy_truncation.cocci > > >=20 > > > Signed-off-by: Dominique Martinet =20 > >=20 > > Applied to the togreg branch of iio.git and pushed out as testing > > for the autobuilders to play with it. =20 >=20 > Thanks! >=20 > I have been pointed out that strlcpy, unlike strncpy, will read past the > size given in the input string and thus is Bad=E2=84=A2 if the input stri= ng is > not nul terminated. >=20 > After taking the time to check I believe this should not happen as the > original name seems to come from a dentry's d_name after proper > preparation (a buffer is allocated precisely for this purpose), but it > will not hurt to wait for that version. >=20 >=20 > The second reason I was waiting is that I intended to check for each > patch if it is safe to not pad the end of the string with zeroes (to > avoid e.g. information leaks) and that seems OK as well here after a > quick check but I wouldn't trust my own eyes this late so I'll let you > be judge of that if you feel like taking v1 anyway. >=20 > Otherwise, I'll recheck properly and submit a v2 with strscpy and a > better commit message after the coccinelle script is taken for inclusion > and doing a better check but this might take a while longer. >=20 >=20 > Thanks, In this particular case I'm fairly sure it is safe so I'll leave it as is. Thanks, Jonathan