linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: ioprio: Replace GFP_ATOMIC with GFP_KERNEL in set_task_ioprio()
Date: Mon, 23 Jul 2018 00:18:04 -0700	[thread overview]
Message-ID: <20180723071803.GA30817@infradead.org> (raw)
In-Reply-To: <20180723022116.6919-1-baijiaju1990@gmail.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

But to me it seems that btrfs and maybe ext4 as well would be much
better off just setting a per-IO priority in the bio.

Any chance yo could look into that?

  reply	other threads:[~2018-07-23  7:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-23  2:21 [PATCH] block: ioprio: Replace GFP_ATOMIC with GFP_KERNEL in set_task_ioprio() Jia-Ju Bai
2018-07-23  7:18 ` Christoph Hellwig [this message]
2018-07-23 12:59   ` Jia-Ju Bai
2018-07-23 21:49   ` Tetsuo Handa
2018-07-24  1:42     ` Jia-Ju Bai
2018-07-24  7:47 ` [LKP] [block] 8448e82606: WARNING:suspicious_RCU_usage kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180723071803.GA30817@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=baijiaju1990@gmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).