From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5058ECDE5F for ; Mon, 23 Jul 2018 09:42:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B83320846 for ; Mon, 23 Jul 2018 09:42:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B83320846 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388309AbeGWKm4 (ORCPT ); Mon, 23 Jul 2018 06:42:56 -0400 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:35178 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388180AbeGWKmz (ORCPT ); Mon, 23 Jul 2018 06:42:55 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1fhXMK-0007tg-Fd; Mon, 23 Jul 2018 11:42:28 +0200 Date: Mon, 23 Jul 2018 11:42:28 +0200 From: Florian Westphal To: Pablo Neira Ayuso Cc: Florian Westphal , David Miller , cscnull@gmail.com, kadlec@blackhole.kfki.hu, johannes.berg@intel.com, Jason@zx2c4.com, ktkhai@virtuozzo.com, lucien.xin@gmail.com, xiyou.wangcong@gmail.com, dsahern@gmail.com, netfilter-devel@vger.kernel.org, tom@quantonium.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netlink: fix memory leak of dump Message-ID: <20180723094228.mejwuvoyitolqktv@breakpoint.cc> References: <20180722143354.23722-1-cscnull@gmail.com> <20180722163925.gdfkndldatsoae6x@breakpoint.cc> <20180722.100755.19840167505550163.davem@davemloft.net> <20180722180910.wcwhantwpm2nfxet@breakpoint.cc> <20180723091551.mwhltw4ujm4bylvj@salvia> <20180723092818.ztsfsnqzxgzrauim@breakpoint.cc> <20180723093855.c4ncixsnkee6r34v@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180723093855.c4ncixsnkee6r34v@salvia> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pablo Neira Ayuso wrote: > > As David pointed out, once ->start() returns 0 we set cb_running, i.e. > > only after successful ->start() netlink core will call ->dump() again. > > > > So I see no problem setting ->data to onstack cookie and then > > duplicating it to heap via kmemdup in ->start(). > > > > As far as I can see netlink core offers all functionality already, > > so we only need to switch netfilter to make use of it. > > > > If you disagree please let me know, otherwise I will cook up > > a patch along this pattern for net/netfilter/*. > > Why not just call ->done from netlink_dump_start() when it fails? Not sure thats safe for all users, we will also still need to call it in nft_netlink_dump_start and we need to play guess game wrt EINTR (which can mean 'dump was now started, do not send ack').