On Sat, Jul 21, 2018 at 10:06:23AM +0000, Marcel Ziswiler wrote: > On Sat, 2018-07-21 at 10:56 +0100, Mark Brown wrote: > > > > > - dev_err(&pdev->dev, "no codec-sync GPIO > > > > > supplied\n"); > > > > > + ret = ac97->sync_gpio; > And here I assign ret with that return value from of_get_named_gpio(), > right? > > It's not in any way involved in setting the value of ret, whatever > > value > > that has it's nothing to do with that operation. > I really do not understand what you are trying to get at, sorry. Didn't see the above assignment you'd added, sorry.