* [PATCH] staging: gasket: use vzalloc instead of vmalloc/memset
@ 2018-07-23 15:05 Ivan Bornyakov
2018-07-23 15:38 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Ivan Bornyakov @ 2018-07-23 15:05 UTC (permalink / raw)
To: devel; +Cc: linux-kernel, gregkh, benchan, jnjoseph, rspringer, Ivan Bornyakov
Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com>
---
drivers/staging/gasket/gasket_page_table.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c
index 9f8116112e0a..3ffc8d67ec05 100644
--- a/drivers/staging/gasket/gasket_page_table.c
+++ b/drivers/staging/gasket/gasket_page_table.c
@@ -330,7 +330,7 @@ int gasket_page_table_init(
pg_tbl = *ppg_tbl;
bytes = total_entries * sizeof(struct gasket_page_table_entry);
if (bytes != 0) {
- pg_tbl->entries = vmalloc(bytes);
+ pg_tbl->entries = vzalloc(bytes);
if (!pg_tbl->entries) {
gasket_nodev_error(
"No memory for address translation metadata.");
@@ -338,7 +338,6 @@ int gasket_page_table_init(
*ppg_tbl = NULL;
return -ENOMEM;
}
- memset(pg_tbl->entries, 0, bytes);
}
mutex_init(&pg_tbl->mutex);
@@ -1067,13 +1066,12 @@ static int gasket_alloc_extended_subtable(
subtable_bytes = sizeof(struct gasket_page_table_entry) *
GASKET_PAGES_PER_SUBTABLE;
- pte->sublevel = vmalloc(subtable_bytes);
+ pte->sublevel = vzalloc(subtable_bytes);
if (!pte->sublevel) {
free_page(page_addr);
memset(pte, 0, sizeof(struct gasket_page_table_entry));
return -ENOMEM;
}
- memset(pte->sublevel, 0, subtable_bytes);
/* Map the page into DMA space. */
if (pg_tbl->dma_ops) {
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: gasket: use vzalloc instead of vmalloc/memset
2018-07-23 15:05 [PATCH] staging: gasket: use vzalloc instead of vmalloc/memset Ivan Bornyakov
@ 2018-07-23 15:38 ` Greg KH
2018-07-23 18:30 ` [PATCH v2] " Ivan Bornyakov
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2018-07-23 15:38 UTC (permalink / raw)
To: Ivan Bornyakov; +Cc: devel, jnjoseph, linux-kernel, rspringer
On Mon, Jul 23, 2018 at 06:05:38PM +0300, Ivan Bornyakov wrote:
> Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com>
> ---
> drivers/staging/gasket/gasket_page_table.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
I can not take patches without any changelog text at all, sorry.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] staging: gasket: use vzalloc instead of vmalloc/memset
2018-07-23 15:38 ` Greg KH
@ 2018-07-23 18:30 ` Ivan Bornyakov
0 siblings, 0 replies; 3+ messages in thread
From: Ivan Bornyakov @ 2018-07-23 18:30 UTC (permalink / raw)
To: devel; +Cc: linux-kernel, gregkh, benchan, jnjoseph, rspringer, Ivan Bornyakov
Use vzalloc instead of vmalloc followed by memset with 0.
Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com>
---
drivers/staging/gasket/gasket_page_table.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c
index 9f8116112e0a..3ffc8d67ec05 100644
--- a/drivers/staging/gasket/gasket_page_table.c
+++ b/drivers/staging/gasket/gasket_page_table.c
@@ -330,7 +330,7 @@ int gasket_page_table_init(
pg_tbl = *ppg_tbl;
bytes = total_entries * sizeof(struct gasket_page_table_entry);
if (bytes != 0) {
- pg_tbl->entries = vmalloc(bytes);
+ pg_tbl->entries = vzalloc(bytes);
if (!pg_tbl->entries) {
gasket_nodev_error(
"No memory for address translation metadata.");
@@ -338,7 +338,6 @@ int gasket_page_table_init(
*ppg_tbl = NULL;
return -ENOMEM;
}
- memset(pg_tbl->entries, 0, bytes);
}
mutex_init(&pg_tbl->mutex);
@@ -1067,13 +1066,12 @@ static int gasket_alloc_extended_subtable(
subtable_bytes = sizeof(struct gasket_page_table_entry) *
GASKET_PAGES_PER_SUBTABLE;
- pte->sublevel = vmalloc(subtable_bytes);
+ pte->sublevel = vzalloc(subtable_bytes);
if (!pte->sublevel) {
free_page(page_addr);
memset(pte, 0, sizeof(struct gasket_page_table_entry));
return -ENOMEM;
}
- memset(pte->sublevel, 0, subtable_bytes);
/* Map the page into DMA space. */
if (pg_tbl->dma_ops) {
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-23 18:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-23 15:05 [PATCH] staging: gasket: use vzalloc instead of vmalloc/memset Ivan Bornyakov
2018-07-23 15:38 ` Greg KH
2018-07-23 18:30 ` [PATCH v2] " Ivan Bornyakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).