From: Ivan Bornyakov <brnkv.i1@gmail.com>
To: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
benchan@chromium.org, jnjoseph@google.com, rspringer@google.com,
Ivan Bornyakov <brnkv.i1@gmail.com>
Subject: [PATCH v2] staging: gasket: use vzalloc instead of vmalloc/memset
Date: Mon, 23 Jul 2018 21:30:25 +0300 [thread overview]
Message-ID: <20180723183025.16550-1-brnkv.i1@gmail.com> (raw)
In-Reply-To: <20180723153853.GA10528@kroah.com>
Use vzalloc instead of vmalloc followed by memset with 0.
Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com>
---
drivers/staging/gasket/gasket_page_table.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c
index 9f8116112e0a..3ffc8d67ec05 100644
--- a/drivers/staging/gasket/gasket_page_table.c
+++ b/drivers/staging/gasket/gasket_page_table.c
@@ -330,7 +330,7 @@ int gasket_page_table_init(
pg_tbl = *ppg_tbl;
bytes = total_entries * sizeof(struct gasket_page_table_entry);
if (bytes != 0) {
- pg_tbl->entries = vmalloc(bytes);
+ pg_tbl->entries = vzalloc(bytes);
if (!pg_tbl->entries) {
gasket_nodev_error(
"No memory for address translation metadata.");
@@ -338,7 +338,6 @@ int gasket_page_table_init(
*ppg_tbl = NULL;
return -ENOMEM;
}
- memset(pg_tbl->entries, 0, bytes);
}
mutex_init(&pg_tbl->mutex);
@@ -1067,13 +1066,12 @@ static int gasket_alloc_extended_subtable(
subtable_bytes = sizeof(struct gasket_page_table_entry) *
GASKET_PAGES_PER_SUBTABLE;
- pte->sublevel = vmalloc(subtable_bytes);
+ pte->sublevel = vzalloc(subtable_bytes);
if (!pte->sublevel) {
free_page(page_addr);
memset(pte, 0, sizeof(struct gasket_page_table_entry));
return -ENOMEM;
}
- memset(pte->sublevel, 0, subtable_bytes);
/* Map the page into DMA space. */
if (pg_tbl->dma_ops) {
--
2.16.4
prev parent reply other threads:[~2018-07-23 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 15:05 [PATCH] staging: gasket: use vzalloc instead of vmalloc/memset Ivan Bornyakov
2018-07-23 15:38 ` Greg KH
2018-07-23 18:30 ` Ivan Bornyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723183025.16550-1-brnkv.i1@gmail.com \
--to=brnkv.i1@gmail.com \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jnjoseph@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).