From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77919C6778A for ; Tue, 24 Jul 2018 06:03:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B54020852 for ; Tue, 24 Jul 2018 06:03:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B54020852 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388299AbeGXHHt (ORCPT ); Tue, 24 Jul 2018 03:07:49 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50506 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388207AbeGXHHt (ORCPT ); Tue, 24 Jul 2018 03:07:49 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 431BC40201A3; Tue, 24 Jul 2018 06:03:02 +0000 (UTC) Received: from localhost (ovpn-8-16.pek2.redhat.com [10.72.8.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 609D616871; Tue, 24 Jul 2018 06:03:01 +0000 (UTC) Date: Tue, 24 Jul 2018 14:02:57 +0800 From: Baoquan He To: Chao Fan Cc: linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, keescook@chromium.org, yasu.isimatu@gmail.com, indou.takao@jp.fujitsu.com, caoj.fnst@cn.fujitsu.com, douly.fnst@cn.fujitsu.com Subject: Re: [PATCH v4 1/4] x86/boot: Add acpitb.h to help parse acpi tables Message-ID: <20180724060257.GE6480@MiWiFi-R3L-srv> References: <20180723092908.32656-1-fanc.fnst@cn.fujitsu.com> <20180723092908.32656-2-fanc.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180723092908.32656-2-fanc.fnst@cn.fujitsu.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 24 Jul 2018 06:03:02 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 24 Jul 2018 06:03:02 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'bhe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi chao, On 07/23/18 at 05:29pm, Chao Fan wrote: > In order to parse ACPI tables, reuse the head file linux/acpi.h, > so that the files in 'compressed' directory can read ACPI table > by including this head file. > > Signed-off-by: Chao Fan > --- > arch/x86/boot/compressed/acpitb.h | 7 +++++++ > 1 file changed, 7 insertions(+) > create mode 100644 arch/x86/boot/compressed/acpitb.h > > diff --git a/arch/x86/boot/compressed/acpitb.h b/arch/x86/boot/compressed/acpitb.h > new file mode 100644 > index 000000000000..f8ab6e5b3e06 > --- /dev/null > +++ b/arch/x86/boot/compressed/acpitb.h > @@ -0,0 +1,7 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#include > + > +#define ACPI_MAX_TABLES 128 > + > +/* Function to get ACPI SRAT table pointer. */ > +struct acpi_table_header *get_acpi_srat_table(void); Since acpitb.h includes so few lines of code, not sure if we can move them into .c files directly. By the way, you might need to rebase this patchset on top of tip/x86/boot. Thanks Baoquan